Media Playback not working

Youtube works for me in a plain webview on the phone, but not in the browser. That's a bit odd :/

This appears to be two separate bugs -
1) There is a problem with User Agent overrides, the above error from YouTube appears to be a "hands in the air", not understanding the level of browser support and so throwing out an rtsp url.
2) There is a (as yet) unknown crash when attempting actual media playback - easily seen on dailymotion, which does not have the same detection logic as YT.

I haven't seen the crash, but what bit of the user agent override fails? I tried looking at the outgoing HTTP headers and navigator.userAgent in the devtools console, and both are as expected

Does reverting http://bazaar.launchpad.net/~oxide-developers/oxide/oxide.trunk/revision/1048 fix it?

Or http://bazaar.launchpad.net/~oxide-developers/oxide/oxide.trunk/revision/1047 ?

It's neither of those 2

It's http://bazaar.launchpad.net/~oxide-developers/oxide/oxide.trunk/revision/1041 that breaks it

IIUC, it looks like the browser loads the UA overrides on the UI thread and then passes them as a property on a QObject to the worker script running on the IO thread:

http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/Ubuntu/Web/UbuntuWebContext.qml#L41

... this would explain why http://bazaar.launchpad.net/~oxide-developers/oxide/oxide.trunk/revision/1041 breaks it, as passing QObjects in messages between threads is no longer allowed (and should never have been allowed really - it's fairly unsafe).

Olivier, is there a way to do that in the browser without using a QObject (ie, just using JSON)?

Actually, I've misread that - it's not sending the QObject. Back to the drawing board

Oh, but the URL's are getting stripped from the data. If I printf("%s\n", qPrintable(doc.toJson())); in OxideQQuickWebContextDelegateWorker::sendMessage, then I see this:

{
    "overrides": [
        [
            null,
            "Mozilla/5.0 (Linux; Ubuntu 14.04 like Android 4.4) AppleWebKit/537.36 Chromium/35.0.1870.2 Mobile Safari"
        ],
        [
            null,
            "Mozilla/5.0 (Linux; Ubuntu 14.04 like Android 4.4;) AppleWebKit/537.36 Chromium/35.0.1870.2 Mobile Safari/537.36"
        ],
        [
            null,
            "Mozilla/5.0 (Linux; Ubuntu 14.04 like Android 4.4;) AppleWebKit/537.36 Chrome/35.0.1870.2 Mobile Safari/537.36"
        ],
        [
            null,
            "Mozilla/5.0 (Linux; Ubuntu 14.04 like Android 4.4;) AppleWebKit/537.36 Chrome/35.0.1870.2 Mobile Safari/537.36"
        ],
        [
            null,
            "Mozilla/5.0 (Linux; Ubuntu 14.04 like Android 4.4;) AppleWebKit/537.36 Chrome/35.0.1870.2 Mobile Safari/537.36"
        ]
    ]
}

Aha, because the regular expressions are not valid JSON

I've reverted bug 1445673

Chris: if that helps, we could probably encode regexps as strings before passing them around, and decoding them again on the other side (not tested, but this should work).

Can you use the RegExp constructor on both sides? That should work.

Shall we take that discussion to bug 1445673? I'll add a webbrowser-app task there

/both sides/the worker side/