manager should set filter_function and goodness_function

Bug #1458061 reported by Danny Wilson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Danny Wilson
Kilo
Fix Released
Undecided
Unassigned

Bug Description

Right now cinder manager does not fill in filter_function or goodness_function from cinder.conf. Driver has to return the functions in get_volume_stats to make it work.

Fix is to have manager fill in the functions from cinder.conf if the driver does not return them.

affects: os-brick → cinder
Changed in cinder:
assignee: nobody → Danny Wilson (daniel-wilson)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/190695

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/190695
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=cbc708b13982bc11eb4956c9f3f1f96f009dafff
Submitter: Jenkins
Branch: master

commit cbc708b13982bc11eb4956c9f3f1f96f009dafff
Author: Daniel Wilson <email address hidden>
Date: Wed Jun 10 14:32:49 2015 -0700

    Volume manager should set filter_function and goodness_function

    If a user defines a filter_function or goodness_function in their cinder.conf
    file the scheduler should use that function. This change appends those
    functions to volume_stats if the driver has not specified them.

    Change-Id: I76f90aa3c1bda7564185d8e130926af7d0827e0e
    Closes-Bug: #1458061

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/201299

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/kilo)

Reviewed: https://review.openstack.org/201299
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=3388fffa0566f7ec43087772e3162869c96cf1ff
Submitter: Jenkins
Branch: stable/kilo

commit 3388fffa0566f7ec43087772e3162869c96cf1ff
Author: Daniel Wilson <email address hidden>
Date: Wed Jun 10 14:32:49 2015 -0700

    Volume manager should set filter_function and goodness_function

    If a user defines a filter_function or goodness_function in their cinder.conf
    file the scheduler should use that function. This change appends those
    functions to volume_stats if the driver has not specified them.

    Change-Id: I76f90aa3c1bda7564185d8e130926af7d0827e0e
    Closes-Bug: #1458061
    (cherry picked from commit cbc708b13982bc11eb4956c9f3f1f96f009dafff)

tags: added: in-stable-kilo
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.