"version" field doesn't get injected properly into task specifications when using spec_parser.get_task_spec()

if that info help :
Encountered this issue for the task in test : "test_get_task_execution_result"

File "mistral/workbook/parser.py", line 49, in _get_spec_version if 'version' in spec_dict: TypeError: argument of type 'NoneType' is not iterable

Please see this test: https://github.com/openstack/mistral/blob/master/mistral/tests/unit/workbook/v2/test_workbook.py#L30-L221

Version injection also is tested there, see lines 37, 48, 69, 84, 105, 116 and 140.

I really don't know how is this test executed with error: it is always successful for me. Could you please add more details on that?

Ooh, it seems like that test (test_get_task_execution_result) is a bit incorrect: https://github.com/openstack/mistral/blob/master/mistral/tests/unit/engine/test_dataflow.py#L465

Please see, here we manually create a task execution object without the spec. That's why it is 'None' for this test. Adding simple task spec should solve this problem.

I know. This is what I thought ...

So actually test need a fix . I started to add manually in the code : 'version' and then 'workflow_type' ...
But since I didnt want to touch too much in this test I advise with Renat and then we opened the bug.

If you want me to work on I need an example how to add "simple task spec" .

Yes. Simple task spec is dict in TaskExecution object and we can create it using:

TaskExecution(
name='task1',
spec={
                "version": '2.0',
                'name': 'task1',
                'with-items': 'var in [1]',
                'type': 'direct'
            }
)

and then we can import parser in dataflow.py and get the TaskSpec object:

from mistral.workbook import parser

...

task_spec = parser.get_task_spec(task_ex.spec)

ooh, indentation is really bad