Retry continues even though task succeeded

Bug #1469330 reported by Winson Chan
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
High
Lingxian Kong

Bug Description

If a task succeed, the retries continue anyway instead of breaking. There's no continue-on and break-on specified. The bug seems to originate at https://github.com/openstack/mistral/blob/master/mistral/engine/policies.py#L291. states.is_completed returns true for SUCCESS and ERROR. So basically if the task is success, it'll continue with retry again.

Changed in mistral:
importance: Undecided → High
milestone: none → liberty-2
Revision history for this message
Lingxian Kong (kong) wrote :

the reason is not due to its continuation with 'success' status, it's because the inappropriate condition at https://github.com/openstack/mistral/blob/master/mistral/engine/policies.py#L307

Changed in mistral:
status: New → Confirmed
assignee: nobody → Lingxian Kong (kong)
Changed in mistral:
status: Confirmed → In Progress
Revision history for this message
Lingxian Kong (kong) wrote :
Changed in mistral:
status: In Progress → Fix Committed
Changed in mistral:
status: Fix Committed → Fix Released
Changed in mistral:
milestone: liberty-2 → liberty
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.