Cinder

Pure drivers retyping to same backend requires migrate

Bug #1477780 reported by Patrick East
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Patrick East
Cinder 7.0.0 "liberty"

Bug Description

If someone has two volume types each maybe having different Cinder QoS settings associated with them, or even just different names which can both end up on the same Pure Storage backend, when doing a retype it should not require doing a migrate.

As far as the actual array is concerned there is no difference between the volumes. It looks like right now both FC and iSCSI drivers are inheriting the default implementation of retype which returns False, None. If we change to simply return True, None it should give the desired behavior.

Patrick East (patrick-east)
Changed in cinder:
assignee: nobody → Patrick East (patrick-east)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/205318

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/205318
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=c6026a2cb223e500e5b522efbba7ecf5bf63c50a
Submitter: Jenkins
Branch: master

commit c6026a2cb223e500e5b522efbba7ecf5bf63c50a
Author: Patrick East <email address hidden>
Date: Thu Jul 23 16:02:43 2015 -0700

    Implement retype for Pure drivers

    Currently retyping on the same backend requires a migration to occur
    due to using the default implementation of retype on the base volume
    driver.

    Volumes on the Pure arrays do not have any differentiation
    between volume types Cinder may be using. Because of this we can
    implement a retype method that will be used whenever changing
    types on the same backend that essentially does nothing except return.

    Change-Id: Ibf4c57166fe5742cc7e079c4422f7efd2b6dce79
    Closes-Bug: 1477780

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/205614

Doug Hellmann (doug-hellmann)
Changed in cinder:
milestone: none → liberty-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (stable/kilo)

Change abandoned by Matt Riedemann (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/205614
Reason: -1 since July, so I'm going to abandon this.

Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-2 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.