OpenStack Heat

Don't raise NotFound exception if nested stack not exist

Bug #1479579 reported by huangtianhua
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
huangtianhua
OpenStack Heat 5.0.0 "liberty"
Kilo
Fix Released
High
Angus Salkeld
OpenStack Heat 2015.1.3

Bug Description

1. Stack.load() won't return None, instead will raise notFound exception if we can't get the stack from db. So we should catch the notFound exception in StackResource.nested() when loading.

2. Return None if we catch the notFound when get the nested, due there are many places where we call the nested(), and raise the notFound exception makes no sense.

huangtianhua (huangtianhua)
Changed in heat:
assignee: nobody → huangtianhua (huangtianhua)
OpenStack Infra (hudson-openstack)
Changed in heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/206974
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=b101190f3261535daf5848a5a77e8902f3a7a4a1
Submitter: Jenkins
Branch: master

commit b101190f3261535daf5848a5a77e8902f3a7a4a1
Author: huangtianhua <email address hidden>
Date: Wed Jul 29 14:25:22 2015 +0800

    Don't raise exception when get nested stack

    1. Stack.load() won't return None, instead will raise
    notFound exception if we can't get the stack from db.
    So we should catch the notFound exception in
    StackResource.nested() when loading.
    2. Return None if we catch the notFound when get the
    nested, due there are many places where we call the
    nested(), and raise the notFound exception makes no sense.

    Closes-Bug: #1479579
    Change-Id: I2540ca13572dfe628e6fc596815bee427b41290f

Changed in heat:
status: In Progress → Fix Committed
Steve Baker (steve-stevebaker)
Changed in heat:
importance: Undecided → High
tags: added: kilo-backport-potential
Changed in heat:
milestone: none → liberty-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/216481

Doug Hellmann (doug-hellmann)
Changed in heat:
status: Fix Committed → Fix Released
Angus Salkeld (asalkeld)
tags: removed: kilo-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/kilo)

Reviewed: https://review.openstack.org/216481
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=e889d66e07183d34849273ae68dc096c0616fa21
Submitter: Jenkins
Branch: stable/kilo

commit e889d66e07183d34849273ae68dc096c0616fa21
Author: Steve Baker <email address hidden>
Date: Tue Aug 25 13:38:07 2015 +1200

    Don't raise exception when get nested stack

    1. Stack.load() won't return None, instead will raise
    notFound exception if we can't get the stack from db.
    So we should catch the notFound exception in
    StackResource.nested() when loading.
    2. Return None if we catch the notFound when get the
    nested, due there are many places where we call the
    nested(), and raise the notFound exception makes no sense.

    (cherry-picked from b101190f3261535daf5848a5a77e8902f3a7a4a1)
    Closes-Bug: #1479579
    Change-Id: I2540ca13572dfe628e6fc596815bee427b41290f

Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-3 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.