OpenStack DBaaS (Trove)

Refactor code in change_permissions function for couchdb

Bug #1481979 reported by Ishita Mandhan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Low
Ishita Mandhan
OpenStack DBaaS (Trove) next

Bug Description

The code in the change_permissions function in service.py can be improved by reducing the number of lines. This can be done by creating constants in the system.py file.

Ishita Mandhan (imandhan)
Changed in trove:
assignee: nobody → Ishita Mandhan (imandha)
Ishita Mandhan (imandhan)
summary: - Refactor change_permissions in couchdb
+ Refactor code in change_permissions function for couchdb
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/210170

Changed in trove:
status: New → In Progress
Nikhil Manchanda (slicknik)
Changed in trove:
importance: Undecided → Low
milestone: none → liberty-rc1
Revision history for this message
Nikhil Manchanda (slicknik) wrote :

This is not blocking for Liberty-RC1 and can come in for Mitaka.

Changed in trove:
milestone: liberty-rc1 → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/210170
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=c191a09772addbf1300daab632aee47cfd756ebb
Submitter: Jenkins
Branch: master

commit c191a09772addbf1300daab632aee47cfd756ebb
Author: Ishita Mandhan <email address hidden>
Date: Thu Aug 6 18:00:51 2015 -0700

    Code refactoring for couchdb

    The code in the change_permissions function for couchdb in service.py was
    refactored. In addition, translation was added to several RuntimeError messages
    that were missing the underscore for translation. Replaced shell calls with the
    respective operating_system service commands - start/stop/ enable/disable/
    change permissions and modified tests as necessary. Created operating_system
    service command change_user_group and associated tests.

    Change-Id: I9605ea30d3b8e5ced532394bbdbccd6ac3747721
    Closes-Bug: #1481979

Changed in trove:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/trove 5.0.0.0b2

This issue was fixed in the openstack/trove 5.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.