Cinder

On migrate we lose track of volume if source deletion failed

Bug #1483155 reported by Gorka Eguileor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Gorka Eguileor
Cinder 7.0.0 "liberty"

Bug Description

When finalizing a volume migration (on migration or retype with migration) we may lose track of the source volume in the back-end if the deletion of the source volume fails.

This happens because we don't want to fail the migration on the source volume failure, so we go ahead with the finalization where we overwrite source's DB entry with destination/temporary volume's entry, losing track of the failed volume deletion; it is no longer referenced by any DB entry while it is still present in the storage back-end.

Gorka Eguileor (gorka)
Changed in cinder:
assignee: nobody → Gorka Eguileor (gorka)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/211257

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/211257
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=cdf5e92f10fe8d097f91f6f63a2c77f6ab2bcdb8
Submitter: Jenkins
Branch: master

commit cdf5e92f10fe8d097f91f6f63a2c77f6ab2bcdb8
Author: Gorka Eguileor <email address hidden>
Date: Mon Aug 10 18:37:27 2015 +0200

    Make migration's volume source deletion async

    Currently source volume deletion on a volume migration (and therefore on
    retype with migration as well) is synchronous and that has 2 problems:

    1. If the deletion takes more than rpc_response_timeout then when
    performed on in-use volumes it will fail.

    2. If the deletion fails then the volume will be left in the back-end
    and Cinder will no longer have a reference of that volume in the DB.

    This patch makes source volume deletion asynchronous resolving both
    issues.

    Closes-Bug: #1483155
    Closes-Bug: #1483157
    Change-Id: I55c3d86660f90044a56b8609bb5774d4f5481227

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-3 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.