oslo.versionedobjects 0.8.0 release causing py27/py34 unittests to fail in ironic

Bug #1488270 reported by John L. Villalovos
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Critical
Tan Lin

Bug Description

Just recently when running:
tox -v -v -epy27 -r
<snip>

Traceback (most recent call last):
  File "ironic/tests/objects/test_objects.py", line 160, in test_obj_to_primitive_recursive
    class MyList(base.ObjectListBase, base.IronicObject):
  File "/home/john/openstack/ironic/.tox/py27/lib64/python2.7/abc.py", line 87, in __new__
    cls = super(ABCMeta, mcls).__new__(mcls, name, bases, namespace)
TypeError: Error when calling the metaclass bases
    metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases
======================================================================
FAIL: ironic.tests.objects.test_objects.TestUtils.test_obj_to_primitive_list
tags: worker-0
----------------------------------------------------------------------
Empty attachments:
  pythonlogging:''
  stderr
  stdout

Traceback (most recent call last):
  File "ironic/tests/objects/test_objects.py", line 146, in test_obj_to_primitive_list
    class MyList(base.ObjectListBase, base.IronicObject):
  File "/home/john/openstack/ironic/.tox/py27/lib64/python2.7/abc.py", line 87, in __new__
    cls = super(ABCMeta, mcls).__new__(mcls, name, bases, namespace)
TypeError: Error when calling the metaclass bases
    metaclass conflict: the metaclass of a derived class must be a (non-strict) subclass of the metaclasses of all its bases
Ran 2541 tests in 7.371s (-0.279s)
FAILED (id=31, failures=2, skips=15)
error: testr failed (1)
ERROR: InvocationError: "/usr/bin/bash -c TESTS_DIR=./ironic/tests/ python setup.py testr --slowest --testr-args=''"
py27 finish: runtests after 14.84 seconds
_____________________________________________________________________________________________________ summary _____________________________________________________________________________________________________
ERROR: py27: commands failed

Tags: oslo
Revision history for this message
Robert Collins (lifeless) wrote :

[openstack-announce] [release][oslo] oslo.versionedobjects release 0.8.0 (liberty) <- smoking correlation batman.

summary: - py27/py34 unittests failing for ironic
+ oslo.versionedobjects 0.8.0 release causing py27/py34 unittests to fail
+ in ironic
tags: added: oslo
Changed in ironic:
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/216472

Changed in ironic:
assignee: nobody → Dan Smith (danms)
status: New → In Progress
Revision history for this message
John L. Villalovos (happycamp) wrote :

https://review.openstack.org/#/q/project:openstack/nova+topic:bp/use-oslo-objects,n,z

Discussion on IRC about the issue:
  dansmith
  dims
  jlvillal

Revision history for this message
John L. Villalovos (happycamp) wrote :
Revision history for this message
Tan Lin (tan-lin-good) wrote :

This is because we use list as field, we should use object_fields.ListOfObjectsField('IronicObject')
https://review.openstack.org/#/c/213601/ can fix this.

Another option is remove ObjectListBase as we don't use it anywhere

Changed in ironic:
assignee: Dan Smith (danms) → Tan Lin (tan-lin-good)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/213601
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=6186a9de2a0c74daf210ca85a0db877bae766594
Submitter: Jenkins
Branch: master

commit 6186a9de2a0c74daf210ca85a0db877bae766594
Author: Lin Tan <email address hidden>
Date: Tue Aug 25 10:46:40 2015 +0800

    Remove ObjectListBase

    ObjectListBase is not used in Ironic at the moment, we should add it
    when it is necessary.

    Partial-Bug: #1488270
    Change-Id: Ifc2aaa1fa09d95f1cfa6ed488f10871666b7fb3d

Ruby Loo (rloo)
Changed in ironic:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by Dan Smith (<email address hidden>) on branch: master
Review: https://review.openstack.org/216472

Changed in ironic:
milestone: none → 4.1.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.