Cinder

provide mechanism to update provider_id on snapshots during backend init

Bug #1489182 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
John Griffith
Cinder 7.0.0 "liberty"

Bug Description

During the Liberty release we added the provider_id column for drivers to use as internal to cinder resource mappings. We also added a method to the manager to call drivers and init this passing in the volumes for said host on init.

Snapshots has the same problem, it would be good to provide a method interface that passes in this info for updates. Currently there's a number of drivers making db get calls in the driver, it would be nice if we could move those out and isolate the db calls to the manager if possible.

Deepti Ramakrishna (dramakri)
Changed in cinder:
assignee: nobody → Deepti Ramakrishna (dramakri)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/219864

Changed in cinder:
assignee: Deepti Ramakrishna (dramakri) → John Griffith (john-griffith)
status: New → In Progress
Jay Bryant (jsbryant)
Changed in cinder:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/219864
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=6eb7d08aa72786c9494fb039f81e9810d494ab87
Submitter: Jenkins
Branch: master

commit 6eb7d08aa72786c9494fb039f81e9810d494ab87
Author: John Griffith <email address hidden>
Date: Wed Sep 2 20:08:49 2015 +0000

    Add mechanism to update snapshot provider_id

    During the L release we added the ability to store
    provider_id info for volumes and snapshots. We did
    not however add a mechanism for this info to be updated
    on upgrades.

    This patch adds on to the volume update mechanism and
    gives a driver the opportunity to set provider_id columns
    that aren't set on snapshots just as it does for volumes.

    Change-Id: Ie6585e4f0d2a4a511e5fbe35b91186d8ad7e9874
    Closes-Bug: #1489182

Changed in cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/221821

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/221821
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=ba0a12d52f7aa044d36f43dbe003858a29142bab
Submitter: Jenkins
Branch: master

commit ba0a12d52f7aa044d36f43dbe003858a29142bab
Author: John Griffith <email address hidden>
Date: Wed Sep 9 15:15:31 2015 +0000

    Pass in snapshot refs for host on provider_update

    Now that snapshot_get_by_host is fixed we can and should
    pass in a list of snapshot-refs to the drivers update_provider
    method (just like we do with volumes).

    Change-Id: I062efd1b7ab16f3f999464d3190c204026bba5ec
    Closes-Bug: #1489182

Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-rc1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.