Migration: LVM volume migration may end up with the additional volume in destination VG of on the same host

The code in https://review.openstack.org/#/c/187270/ should resolve this.

@Jon, I do not think you get my point exactly.
This issue needs to be resolved in the method migrate_volume from the LVM driver.
I will give the fix.

Fix proposed to branch: master
Review: https://review.openstack.org/218750

Reviewed: https://review.openstack.org/187270
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f586043fa969b9d1dcf4933aacbf615f53691093
Submitter: Jenkins
Branch: master

commit f586043fa969b9d1dcf4933aacbf615f53691093
Author: Jon Bernard <email address hidden>
Date: Mon Jun 1 14:09:30 2015 -0400

    Add support for file I/O volume migration

    This patch changes the generic volume migration logic to support
    non-attachable volumes. Non-attachable refers to volume drivers that do
    not support attachment via the typical iSCSI or similar protocols where
    a block device is made available on the host machine. Device drivers
    such as RBD make volumes available to cinder via a file handle that
    proxies read() and write() calls to the Ceph cluster.

    This patch improves the generic migration logic to determine whether a
    migration operation can proceed with dd using block device paths or file
    operations on handles returned from the os-brick connectors.

    Changes to the RBD driver are included to correctly rename the target
    volume during the completion phase of a successful migration.

    It appears there is still some work to be done for attached in-use
    volume migration for certain configurations. Successful tests were seen
    for:

      LVM to LVM (available and in-use)
      LVM to/from NFS (available and in-use)
      LVM to/from Ceph (available)
      Ceph to LVM (in-use)
      NFS to/from Ceph (available)
      Ceph to NFS (in-use)

    Failures were seen (due to Nova) for the following:

      LVM to Ceph (in-use)
      NFS to Ceph (in-use)

    (Pulled from gate, cinder can no longer pass unit tests)

    Blueprint: generic-volume-migration
    Closes-Bug: #1489335
    Closes-Bug: #1489337
    Change-Id: Iece2776fa751152f97b389ddab426e50c6f79bea

This one is not fixed. I will give the fix

Reviewed: https://review.openstack.org/218750
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=224688ce914444531181af9dff1ce794d7108490
Submitter: Jenkins
Branch: master

commit 224688ce914444531181af9dff1ce794d7108490
Author: Vincent Hou <email address hidden>
Date: Mon Aug 31 15:14:37 2015 +0800

    LVM: add the exception handling to volume copy

    If the volume copy fails from one vg to another one on
    the same host, the destination volume on the destination
    pool should be removed.

    Change-Id: I41922e197e09827582e660a6a00b86aa7044093e
    Closes-Bug: #1489335