Cinder

VMware: Unformatted exception message

Bug #1491834 reported by Vipin Balachandran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Vipin Balachandran
Cinder 7.0.0 "liberty"

Bug Description

How to reproduce?
Set vmware_cluster_name = test-cluste2 in cinder.conf where 'test-cluste2' is an invalid cluster in vCenter.

2015-08-26 16:39:11.963 ERROR cinder.volume.drivers.vmware.volumeops [req-7d4c8014-023a-4c70-8736-861ee3330985 None None] Compute cluster: test-cluste2 not found.
2015-08-26 16:39:11.963 ERROR cinder.volume.manager [req-7d4c8014-023a-4c70-8736-861ee3330985 None None] Failed to initialize driver.
2015-08-26 16:39:11.963 TRACE cinder.volume.manager Traceback (most recent call last):
2015-08-26 16:39:11.963 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/manager.py", line 307, in init_host
2015-08-26 16:39:11.963 TRACE cinder.volume.manager self.driver.do_setup(ctxt)
2015-08-26 16:39:11.963 TRACE cinder.volume.manager File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
2015-08-26 16:39:11.963 TRACE cinder.volume.manager return f(*args, **kwargs)
2015-08-26 16:39:11.963 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/vmware/vmdk.py", line 1897, in do_setup
2015-08-26 16:39:11.963 TRACE cinder.volume.manager cluster_names).values()
2015-08-26 16:39:11.963 TRACE cinder.volume.manager File "/opt/stack/cinder/cinder/volume/drivers/vmware/volumeops.py", line 1499, in get_cluster_refs
2015-08-26 16:39:11.963 TRACE cinder.volume.manager raise vmdk_exceptions.ClusterNotFoundException(cluster=name)
2015-08-26 16:39:11.963 TRACE cinder.volume.manager ClusterNotFoundException: Compute cluster: %(cluster)s not found.
2015-08-26 16:39:11.963 TRACE cinder.volume.manager

The exception message should be "Compute cluster: test-cluste2 not found"

Tags: drivers vmware
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/220132

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/220132
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d8143fe77be0544ed4f05ec02597dc979a60c66e
Submitter: Jenkins
Branch: master

commit d8143fe77be0544ed4f05ec02597dc979a60c66e
Author: Vipin Balachandran <email address hidden>
Date: Tue Aug 25 14:36:51 2015 +0530

    VMware: Fix exception messages

    Currently some of the exceptions defined in the VMware driver
    emit unformatted error messages. This is because they are
    not overriding the correct message format variable. This
    patch fixes the issue by overriding the correct variable
    defined in the exception super class.

    Closes-Bug: #1491834
    Change-Id: I1c66d60ab2ea402dd944587b3d8b6d7c293c4d85

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-rc1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.