bagpipe driver should ignore router and dhcp ports

Bug #1492349 reported by Thomas Morin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-bgpvpn
Fix Released
Low
Thomas Morin

Bug Description

Bagpipe driver should not advertise DHCP and router interface in BGP VPNs.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-bgpvpn (master)

Reviewed: https://review.openstack.org/221007
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=9dac6d3321681b3619f4b96bb7801c2c7e4cd611
Submitter: Jenkins
Branch: master

commit 9dac6d3321681b3619f4b96bb7801c2c7e4cd611
Author: Thomas Morin <email address hidden>
Date: Wed Jul 1 12:10:10 2015 +0200

    Bagpipe driver: use Neutron registry not an ML2 MD

    This change makes the bagpipe driver use the Neutron
    registry callbacks instead of a custom ML2 mech driver.

    The now obsolete bgpvpn_notify mech driver still exists
    to avoid breaking past configs, but it is empty and logs
    a warning on startup.

    With this change, the bagpipe driver also stops
    preventing network deletion, because without a mech driver
    we can't, which is good since it fixes bug 1489881.

    This change also changes the behavior to ignore DHCP ports.

    Implements: blueprint bagpipe-use-neutron-registry
    Closes-Bug: 1489881
    Partial-Bug: 1492349
    Change-Id: I0dcfbadd222ad1f9768f4546118cb311fbfbdb51

Revision history for this message
Thomas Morin (tmmorin-orange) wrote :

I will close this bug, because DHCP is now covered and I think we shouldn't ignore Router Ports.

Changed in bgpvpn:
status: New → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/224553
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=90e444a29e957366bf156b0684fbbbd1d160e35e
Submitter: Jenkins
Branch: master

commit 90e444a29e957366bf156b0684fbbbd1d160e35e
Author: Thomas Morin <email address hidden>
Date: Thu Sep 17 12:00:19 2015 +0200

    bagpipe driver: missing return to ignore DHCP ports

    Really ignore DHCP ports (there were two missing returns).
    (+fixes in a few log messages).

    Also adds new test cases on to check the callbacks-to-RPC
    logic, including one to confirm that DHCP port are indeed
    ignored.

    Change-Id: I32fd6f7927388677bc506b5b550b7e9a0c8012e6
    Partial-Bug: 1492349

Changed in bgpvpn:
assignee: nobody → Thomas Morin (tmmorin-orange)
milestone: none → liberty
Changed in bgpvpn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.