Cinder

PureFCDriver has unhelpful log tracing when initialize_connection is called

Bug #1494459 reported by Patrick East
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Patrick East
Cinder 7.0.0 "liberty"

Bug Description

For example

2015-09-10 17:43:32.521 DEBUG cinder.volume.drivers.pure [req-25e3d691-7227-4ef3-a8a6-f9fe1d7e1906 tempest-VolumesBackupsV1Test-1537472774] Enter PureFCDriver.decorator wrapper /opt/stack/new/cinder/cinder/volume/drivers/pure.py:74

I think this is caused by the trace decorator method being on top of the FCZM decorator, if we swap them it should actually log the right method name.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222353

Changed in cinder:
assignee: nobody → Patrick East (patrick-east)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/222353
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=3474ca236de44bb4ccc11d864554f1922f6c64ae
Submitter: Jenkins
Branch: master

commit 3474ca236de44bb4ccc11d864554f1922f6c64ae
Author: Patrick East <email address hidden>
Date: Thu Sep 10 13:00:27 2015 -0700

    Swap the decorator order for PureFCDriver methods

    Right now the debug trace decorator is logging the decorator method from
    the FCZM helper and not the actual driver methods its supposed to be.

    Change-Id: If658393e5e9d1b3e068fc7a200998e8033ada48f
    Closes-Bug: #1494459

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-rc1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.