Cinder

Relying on provider_id from database for SolidFire deletes is a bad idea

Bug #1494597 reported by John Griffith
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
John Griffith
Cinder 7.0.0 "liberty"

Bug Description

After working on incorporating the use of provider_id fields in the SolidFire driver, I realized there's some flaws here. The main one being that the implementation currently in the driver doesn't account for things like a failed create.

populating provider-id fields in the db isn't harmful, but it's probably best not to rely on it. There are other/better ways to optimize lookups in our case.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222484

Changed in cinder:
assignee: nobody → John Griffith (john-griffith)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/222484
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=1525bb4d8e99b1b948fe079f15e400a8262c1f5e
Submitter: Jenkins
Branch: master

commit 1525bb4d8e99b1b948fe079f15e400a8262c1f5e
Author: John Griffith <email address hidden>
Date: Fri Sep 11 06:21:40 2015 +0000

    Don't rely on provider_id for resource deletion

    Provider_id info isn't necessarily reliable when dealing
    with failure cases. There are a number of cases where the
    info in the Cinder database may not be updated.

    This change uses the old delete routines instead of trying
    to use the provider_id info. There are ways to do both,
    however it's probably not that beneficial for now.

    Change-Id: Idbfd98b19f3c7f1b231ed26a2cc6c98aa2899e2a
    Closes-Bug: #1494597

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → liberty-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-rc1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.