Making opt names consistent bug fix broke dothill, hpmsa and lenovo drivers

Bug #1494877 reported by Nikesh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Critical
Walt Boring

Bug Description

Making opt names consistent bug fix broke dothill, hpmsa and lenovo drivers

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/222731

Changed in cinder:
assignee: nobody → Walt Boring (walter-boring)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/222733

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/222736

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/222731
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=a93c0b727a239d0d4ab5f4b094ea0df6a83623fb
Submitter: Jenkins
Branch: master

commit a93c0b727a239d0d4ab5f4b094ea0df6a83623fb
Author: Walter A. Boring IV <email address hidden>
Date: Fri Sep 11 18:32:29 2015 +0000

    Dothill fix options access

    This patch fixes invalid access to the options that live
    in the dothill_common. They were recently renamed from
    common_opt to common_opts, but the drivers weren't updated.

    Change-Id: Iff411239a079f76c874b7b11f01a21f5f7d9f12e
    Partial-Bug: 1494877

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/222736
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0957af28127bf9d8acd803c5d90f43f387b8924a
Submitter: Jenkins
Branch: master

commit 0957af28127bf9d8acd803c5d90f43f387b8924a
Author: Walter A. Boring IV <email address hidden>
Date: Fri Sep 11 18:37:53 2015 +0000

    HPMSA fix access to common options

    This patch fixes access to the options defined in
    hpmsa_common. They were recently renamed from common_opt
    to common_opts, but the drivers weren't updated.

    Change-Id: I381e61c8e44454f29bc6ff6f1a5a82bbc8ab9436
    Partial-Bug: 1494877

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/222733
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=49fec70e991cd01eacf7ecf94614be96deb5d19d
Submitter: Jenkins
Branch: master

commit 49fec70e991cd01eacf7ecf94614be96deb5d19d
Author: Walter A. Boring IV <email address hidden>
Date: Fri Sep 11 18:35:19 2015 +0000

    Lenovo driver fix access to common opts

    This patch fixes access to the lenovo_common options.
    They were recently renamed from common_opt to common_opts,
    but the drivers weren't updated.

    Change-Id: I63583394d58cb8fc791787df35ed04d30113fafe
    Partial-Bug: 1494877

Revision history for this message
Nikesh (nikesh-mahalaka) wrote :

In recent merge of "https://github.com/openstack/cinder/commit/1fd83e14d28e18569af63ee2882dc174eacec3ac" , for making opt names consistent, common_opt and iscsi_opt were changed to common_opts and iscsi_opts in dothill_common.py, hpmsa_common.py and lenovo_common.py but same was not changed in dothill_fc.py, dothill_iscsi.py, hpmsa_fc.py, hpmsa_iscsi.py,
lenovo_fc.py and lenovo_iscsi.py.

Fix for this have been merged now.
Thanks to all reviewers.

Changed in cinder:
importance: Undecided → Critical
milestone: none → liberty-rc1
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-rc1 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.