OpenStack Heat

template-validate fails when resources are swaped with None resource

Bug #1495914 reported by Kanagaraj Manickam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Steven Hardy
OpenStack Heat 5.0.0 "liberty"

Bug Description

1. Create a template with a sample resource say OS::Nova::Server with some properties in it
2. Create a resource_registry to swap it as below
     resource_registry:
         "OS::Nova::Server" : "OS::Heat::None"
3. validate the template using template-validate command with this resource_registry.

It failed with below error:
ERROR: Property error: <resource name>.Properties: Unknown Property <property name>

Kanagaraj Manickam (kanagaraj-manickam)
Changed in heat:
assignee: nobody → Kanagaraj Manickam (kanagaraj-manickam)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/223528

Changed in heat:
status: New → In Progress
Steve Baker (steve-stevebaker)
Changed in heat:
importance: Undecided → Medium
milestone: none → next
Revision history for this message
Steven Hardy (shardy) wrote :

I think this is basically a manifestation of the generall "validate doesn't behave the same as create" bug #1467573 I raised, and my fix should address this issue too - if so we could mark this as a duplicate of that bug, or mark my patch for that as closing this (subject to confirmation from kanagaraj-manickam that is does - I did a quick test and I think it should).

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/225263

Changed in heat:
assignee: Kanagaraj Manickam (kanagaraj-manickam) → Steven Hardy (shardy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/225263
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=8ea9f81a996e0385054d87fb3db1d6eba2cf235d
Submitter: Jenkins
Branch: master

commit 8ea9f81a996e0385054d87fb3db1d6eba2cf235d
Author: Steven Hardy <email address hidden>
Date: Fri Sep 18 18:19:40 2015 +0100

    Add a functional test proving OS::Heat::None works with validate

    Previously the template-validate logic failed when overriding
    resources with OS::Heat::None in the resource_registry, despite
    this working fine via create/preview.

    Since the fix for bug #1467573 has aligned the template-validate
    logic with that of create/preview, this should now work.

    Change-Id: Id8d0be57d347e7ef6714477747949bd2dadd470c
    Closes-Bug: #1495914

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by Kanagaraj Manickam (<email address hidden>) on branch: master
Review: https://review.openstack.org/223528
Reason: Abandoning this change as its taken care by https://review.openstack.org/223581 (thanks to shardy)

Steve Baker (steve-stevebaker)
Changed in heat:
milestone: next → liberty-rc1
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-rc1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.