Barbican

Possible async issues with CA repo

Bug #1499105 reported by Dave McCowan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Barbican
Fix Released
Critical
Dave McCowan
Barbican 1.0.0 "liberty"

Bug Description

The CA repo can be read and written from multiple threads.
For this to work, writes to the database should call commit after a transaction cycle.

Some refactor work should be done to refresh_ca_table(), which fixes an async issue, but the implementation isn't quite right.

Other writes to the database for new Liberty features (subCAs and quotas) should be evaluated to fix async issues.

See controllers/orders.py for an example of how to do this. (One line of code per write transaction period).

Dave McCowan (dave-mccowan)
Changed in barbican:
status: New → In Progress
assignee: nobody → Dave McCowan (dave-mccowan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to barbican (master)

Fix proposed to branch: master
Review: https://review.openstack.org/227109

Douglas Mendizábal (dougmendizabal)
Changed in barbican:
milestone: none → liberty-rc1
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to barbican (master)

Reviewed: https://review.openstack.org/227109
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=c494c2582b09fcd4225bf0824fb6f8891c5b9766
Submitter: Jenkins
Branch: master

commit c494c2582b09fcd4225bf0824fb6f8891c5b9766
Author: Dave McCowan <email address hidden>
Date: Thu Sep 24 00:53:19 2015 -0400

    Add database commit for database writes when async operations are possible

    If we expect a database read to arrive asynchronously on a different
    thread than a database write, then any changes from the write should
    be explicitly committed to the database.

    Change-Id: I23ccdb2bf33b1a2d910f71b985f8a86da3824267
    Closes-bug: #1499105

Changed in barbican:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in barbican:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in barbican:
milestone: liberty-rc1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.