Barbican can fail to start if certificate plugin has an error

Bug #1499768 reported by Dave McCowan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Barbican
Fix Released
Medium
Dave McCowan

Bug Description

This relates to ​ Bug #1498717 (SnakeOil CA Should Recover from database loss) which should be fixed in the Snakeoil plugin.

The the to this bug will be, in case a plugin does give bad information, for Barbican to catch the exception, log an error, and continue on to the next action.

Changed in barbican:
status: New → In Progress
assignee: nobody → Dave McCowan (dave-mccowan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to barbican (master)

Fix proposed to branch: master
Review: https://review.openstack.org/227902

Revision history for this message
Douglas Mendizábal (dougmendizabal) wrote :

Is this really a bug? I think we would want to fail if the CA plugin is not configured correctly.

Changed in barbican:
importance: Undecided → Medium
Changed in barbican:
milestone: none → liberty-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to barbican (master)

Reviewed: https://review.openstack.org/227902
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=ec1f1bbebb24db4345d87707f78f50aeef2bd783
Submitter: Jenkins
Branch: master

commit ec1f1bbebb24db4345d87707f78f50aeef2bd783
Author: Dave McCowan <email address hidden>
Date: Fri Sep 25 11:07:43 2015 -0400

    Catch exceptions raised by bad certificate plugin info

    If the Snakeoil plugin's persistent storage gets hosed or out of sync with the
    Barbican database, the plugin can send information that raises an
    exception. This exception needs to be caught. The failure is in
    the plugin, so Barbican can not take guesses. It should log the
    error, cancel the action, and continue.

    Change-Id: Id55eafa0dea2004bf2ab94aadb820bf08bec1468
    Closes-bug: #1499768
    Relates-to: #1498717

Changed in barbican:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in barbican:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in barbican:
milestone: liberty-rc1 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.