Mir

incorrect reporting in mf::SessionMediator::release_buffer_stream()

Bug #1499777 reported by Alan Griffiths
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Low
Alan Griffiths
Mir 0.19.0
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

void mf::SessionMediator::release_buffer_stream(
    const mir::protobuf::BufferStreamId* request,
    mir::protobuf::Void*,
    google::protobuf::Closure* done)
{
    auto session = weak_session.lock();

    if (session.get() == nullptr)
        BOOST_THROW_EXCEPTION(std::logic_error("Invalid application session"));

    report->session_create_surface_called(session->name());

Related branches

lp://qastaging/~alan-griffiths/mir/fix-1499777
PS Jenkins bot (community): Approve (continuous-integration)
Daniel van Vugt: Approve
Alberto Aguirre (community): Approve
Diff: 254 lines (+87/-32)
11 files modified
include/server/mir/frontend/session_mediator_report.h (+4/-0)
src/server/frontend/session_mediator.cpp (+2/-2)
src/server/report/logging/session_mediator_report.cpp (+10/-0)
src/server/report/logging/session_mediator_report.h (+33/-30)
src/server/report/lttng/session_mediator_report.cpp (+3/-0)
src/server/report/lttng/session_mediator_report.h (+2/-0)
src/server/report/lttng/session_mediator_report_tp.h (+2/-0)
src/server/report/null/session_mediator_report.cpp (+8/-0)
src/server/report/null/session_mediator_report.h (+4/-0)
tests/acceptance-tests/test_nested_mir.cpp (+2/-0)
tests/acceptance-tests/test_session_mediator_report.cpp (+17/-0)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Also...

void mf::SessionMediator::create_buffer_stream(
    mir::protobuf::BufferStreamParameters const* request,
    mir::protobuf::BufferStream* response,
    google::protobuf::Closure* done)
{
    auto const session = weak_session.lock();

    if (session.get() == nullptr)
        BOOST_THROW_EXCEPTION(std::logic_error("Invalid application session"));

    report->session_create_surface_called(session->name());

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This would be Medium. But it's a feature that's disabled by default and AFAIK almost nobody knows about or enables. So Low then.

Changed in mir:
importance: Undecided → Low
Alan Griffiths (alan-griffiths)
Changed in mir:
status: New → In Progress
assignee: nobody → Alan Griffiths (alan-griffiths)
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.19.0
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.19.0

Changed in mir:
status: In Progress → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

mir (0.19.0+16.04.20160128-0ubuntu1) xenial; urgency=medium

Changed in mir:
status: Fix Committed → Fix Released
Changed in mir (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.