networking-bgpvpn

get_network_association inconsistency

Bug #1513087 reported by Thomas Morin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-bgpvpn
Fix Released
Medium
Thomas Morin
networking-bgpvpn 3.0.0

Bug Description

When a call is made to GET a said Network association for a said BGPVPN, only the net_association uuid is passed to the driver.
It may thus successfully return a network association that in fact is not linked to this BGPVPN.

Revision history for this message
Thomas Morin (tmmorin-orange) wrote :

Example:
- an association with UUID Z exists between BGPVPN X and Network Y
- another BGPVPN Y exists
- client requests Netork association Z for BGPVPN Y
- the driver is asked by the plugin for net association Z (currently does not specify for which BGPVPN)
- the driver returns the association, and the plugin passes it to the client

-> the client request is successful although he asked for an association on the wrong BGPVPN.

Mathieu Rohon (mathieu-rohon)
Changed in bgpvpn:
assignee: nobody → Mathieu Rohon (mathieu-rohon)
Revision history for this message
Mathieu Rohon (mathieu-rohon) wrote :

After all, the client ask for the the Net_ASSOC Z, and it gets it. Even if it is not attached to the specified bgpvpn, it is the Net_ASSOC it asks for.

It looks like the issue comes from the fact that the bgpvpn has to be specified.

Changed in bgpvpn:
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-bgpvpn (master)

Fix proposed to branch: master
Review: https://review.openstack.org/243605

Changed in bgpvpn:
assignee: Mathieu Rohon (mathieu-rohon) → Thomas Morin (tmmorin-orange)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-bgpvpn (master)

Reviewed: https://review.openstack.org/243605
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=0d0b9d2f5feec6914a900f7b81c894f090cd8cf2
Submitter: Jenkins
Branch: master

commit 0d0b9d2f5feec6914a900f7b81c894f090cd8cf2
Author: Thomas Morin <email address hidden>
Date: Tue Nov 10 14:22:51 2015 +0100

    Checks consistency of net association vs BGPVPN id

    This change introduces checks so that on a GET for a
    network association on a BGPVPN, the network association
    is returned only if it is actually bound to this BGPVPN.

    Change in:
    - plugin/driver interface
    - DB code, to detect inconsistency and raise an error
    - test cases

    Additionally, the code adapts DELETE codepath for the
    same reason.

    Change-Id: I71d9c4b0fc08975c40c8da3a67e1d5837f1b1f73
    Closes-Bug: 1513087

Changed in bgpvpn:
status: In Progress → Fix Committed
Mathieu Rohon (mathieu-rohon)
Changed in bgpvpn:
milestone: none → liberty
Mathieu Rohon (mathieu-rohon)
Changed in bgpvpn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.