Ubuntu Music App

Redundant requests for artist art

Bug #1515067 reported by Michi Henning
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Music App
Fix Released
Low
Victor Thompson
Ubuntu Music App ota10
thumbnailer (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

I'm seeing redundant requests in the thumbnailer for every artist. For example:

thumbnailer-service: [00:33:58.397] "artist: Mamady Keïta/Afö (512,512): 5.732672 [q: 4.476239, d: 1.065771] sec (MISS)"
thumbnailer-service: [00:33:58.439] "artist: Mamady Keïta/ (512,512): 5.774881 [q: 3.434976, d: 2.267816] sec (MISS)"

thumbnailer-service: [00:33:56.041] "artist: Passport/ (512,512): 3.741614 [d: 3.681184] sec (MISS)"
thumbnailer-service: [00:33:56.144] "artist: Passport/Passport to Paradise (512,512): 3.480054 [d: 3.446207] sec (MISS)"

thumbnailer-service: [00:34:02.958] "artist: Pink Floyd/The Dark Side Of The Moon [2011 - Remaster] (512,512): 10.288417 [q: 6.923973, d: 3.262566] sec (MISS)"
thumbnailer-service: [00:34:04.315] "artist: Pink Floyd/ (512,512): 11.646238 [q: 10.182878, d: 1.348939] sec (MISS)"

For every artist, it appears that a request is sent for the artist with an empty album title, plus a request for the artist with an album title. This is not great because it results in two remote server accesses for each artist. This hammers the CPU and the network on the phone, as well as the server on dash.ubuntu.com.

Related branches

lp://qastaging/~vthompson/music-app/fix-1515067
Jenkins Bot: Approve (continuous-integration)
Victor Thompson: Needs Information
Andrew Hayzen: Approve
Michi Henning (community): Needs Information
Facundo Batista: Pending (question about backend semantics) requested
Diff: 47 lines (+2/-21)
2 files modified
app/ui/Artists.qml (+1/-21)
debian/changelog (+1/-0)
Michi Henning (michihenning)
Changed in thumbnailer (Ubuntu):
status: New → Triaged
Victor Thompson (vthompson)
Changed in music-app:
status: New → Confirmed
assignee: nobody → Victor Thompson (vthompson)
status: Confirmed → In Progress
importance: Undecided → Low
Michi Henning (michihenning)
summary: - Redunt requests for artist art
+ Redundant requests for artist art
Revision history for this message
Michi Henning (michihenning) wrote :

This is behaving much better now, thanks!

Victor Thompson (vthompson)
Changed in music-app:
milestone: none → ota10
Revision history for this message
Michi Henning (michihenning) wrote :

I have just confirmed with Facundo that the server does this transparently. In other words, if the application sends artist+album and 7digital returns a failure for this, then the server automatically tries again with just the artist.

So, if the application does this too, we are just wasting resources. The correct behavior appears to be to always send artist+album. If that doesn't return artwork, neither will artist+<empty>.

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

Fix committed into lp:music-app at revision None, scheduled for release in music-app, milestone ota9

Changed in music-app:
status: In Progress → Fix Committed
Revision history for this message
Michi Henning (michihenning) wrote :

I've re-tested with r383 from rc-proposed on Mako, and things are much better behaved now, thanks!

Changed in thumbnailer (Ubuntu):
status: Triaged → Invalid
Victor Thompson (vthompson)
Changed in music-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.