Margin isn't between view switcher and pathbar in RTL
Bug #1516425 reported by
Danielle Foré
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Files |
Fix Released
|
Medium
|
Jeremy Wootten | ||
Bug Description
Looks like the margin that's supposed to go in between the view switcher and the pathbar is being placed to "right" instead of "end"
Related branches
lp://qastaging/~jeremywootten/pantheon-files/fix-1516425-topmenu-margins-in-RTL
- elementary Apps team: Pending requested
-
Diff: 56 lines (+6/-6)3 files modifiedlibwidgets/Chrome/BasicLocationBar.vala (+1/-1)
libwidgets/Chrome/TopMenu.vala (+1/-1)
src/View/PropertiesWindow.vala (+4/-4)
| Changed in pantheon-files: | |
| status: | New → Confirmed |
| Changed in pantheon-files: | |
| importance: | Undecided → Medium |
| assignee: | nobody → Jeremy Wootten (jeremywootten) |
| milestone: | none → feature-future |
Revision history for this message
| Jeremy Wootten (jeremywootten) wrote | #1 |
Revision history for this message
| Danielle Foré (danrabbit) wrote | #2 |
| Changed in pantheon-files: | |
| status: | Confirmed → In Progress |
| Changed in pantheon-files: | |
| milestone: | feature-future → loki-alpha1 |
| Changed in pantheon-files: | |
| status: | In Progress → Fix Committed |
| tags: | removed: bitesize |
| Changed in pantheon-files: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Changing the margin to "end" fixes the bug for the direction at start up. However, if you change the direction while Files is running using Gtk Inspector, the margins are not switched. Presumably a Gtk bug? One solution is for the top menu widgets all to be given symmetrical margins, although this changes the appearance very slightly.