Designate

NO_DOMAIN status from pool-manager isn't being handled

Bug #1522480 reported by Tim Simmons
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
High
Tim Simmons
Designate mitaka-2 "m2"

Bug Description

'The Big Rename' changed this line:
https://github.com/openstack/designate/blob/master/designate/central/service.py#L2371

but not:
https://github.com/openstack/designate/blob/master/designate/mdns/notify.py#L121

So now NO_DOMAIN statuses are being dropped. (There should be an exception when the thing goes unhandled)

Unit test was also updated, so it will still pass:
https://github.com/openstack/designate/blob/master/designate/tests/unit/test_central/test_basic.py#L1919

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/253102

Changed in designate:
assignee: nobody → Tim Simmons (timsim)
status: New → In Progress
Tim Simmons (timsim)
Changed in designate:
importance: Undecided → High
milestone: none → mitaka-1
Tim Simmons (timsim)
Changed in designate:
milestone: mitaka-1 → mitaka-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/253102
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=5333caa09c41a071aa62a29c19a30584f54ad4a8
Submitter: Jenkins
Branch: master

commit 5333caa09c41a071aa62a29c19a30584f54ad4a8
Author: Tim Simmons <email address hidden>
Date: Thu Dec 3 11:34:54 2015 -0600

    Fix NO_DOMAIN handling with The Big Rename

    Some various renamings of the "NO_DOMAIN" concept broke the very delicate
    handling of a target which doesn't have a zone that it should. This
    fixes it.

    Change-Id: I86e537fb2b86196528821f15f1e12291be52ce33
    Closes-Bug: 1522480

Changed in designate:
status: In Progress → Fix Committed
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/designate 2.0.0.0b2

This issue was fixed in the openstack/designate 2.0.0.0b2 development milestone.

Graham Hayes (grahamhayes)
Changed in designate:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.