webclient: No visual indicator for expired accounts in patron summary

Bug #1522599 reported by Kathy Lussier
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned

Bug Description

The color borders previously used as visual indicators in the patron summary have been replaced with a red fonts used to highlight specific problem areas. For example, if the patron owes fines, the Fines Owed label along with the amount owed becomes red.

We need a similar visual indicator to highlight when a patron's account is expired (previously done in xul with a gray border). If the expiration date is in the past, we would like the Expire date label and the actual date to be red to be consistent with the other fields in the web client patron summary.

Revision history for this message
Kathy Lussier (klussier) wrote :

Better yet, show this visual indicator if the patron account expiration date is equal to or before today since circulation functions cut off on the day of circulation.

Related bug is at https://bugs.launchpad.net/evergreen/+bug/1342989 . The proposed solution is a bit different in favor of having consistency in the short-term, even if we ultimately have somebody who makes the change in the circ function.

Revision history for this message
Terran McCanna (tmccanna) wrote :

I agree with Kathy on the desired behavior.

Changed in evergreen:
status: New → Confirmed
Billy Horn (bhorn)
Changed in evergreen:
assignee: nobody → Billy Horn (bhorn)
Revision history for this message
Billy Horn (bhorn) wrote :

I have added a commit here http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bhorn/lp1522599-add-visual-indicator-for-expired-patron

It adds the patron-summary-alert styling to expire date that overdue has. It also adds the styling to the patrons name at the top of the summary, which is turned on for any active alert.

tags: added: pullrequest
Bill Erickson (berick)
Changed in evergreen:
assignee: Billy Horn (bhorn) → nobody
milestone: none → 2.11.1
Revision history for this message
Kathy Lussier (klussier) wrote :

Thank you Billy! The patron expiration date styling is working as expected for me.

I'm curious to hear what others think about the additional styling for the patron's name. The name turns red if there is any kind of Stop Sign alert on the patron's record. I think it works well in most cases, but I wasn't sure it about using it for available holds alerts.

If anyone else wants to look at it, the code is loaded on a test server at https://mlnc2.noblenet.org/eg/staff/ (admin / evergreen123). Let me know what you think!

Revision history for this message
Terran McCanna (tmccanna) wrote :

I like it! Thanks, Billy!

I could go either way on it turning red for holds - it may be useful for people who come in the library and don't realize they have a hold waiting.

Revision history for this message
Kathy Lussier (klussier) wrote :

OK, then, let's go with it. I've picked it to the sprint4 collab branch, which should be merged to master later today. Thanks Billy and Terran!

Changed in evergreen:
status: Confirmed → Fix Committed
milestone: 2.11.1 → 2.next
no longer affects: evergreen/2.10
Changed in evergreen:
milestone: 2.next → 2.12-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.