[UI] Don't check admin role for all tenants at login

Bug #1532666 reported by Biswajit Mandal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.20
Fix Committed
Medium
Biswajit Mandal
R2.21.x
Fix Committed
Medium
Biswajit Mandal
R2.22.x
Fix Committed
Medium
Biswajit Mandal
Trunk
Fix Committed
Medium
Biswajit Mandal

Bug Description

Don't check admin role for all tenants at login.

Today we check that a user has admin role in all projects at login time. Instead of this, allow login if the last project has admin role.

Tags: ui
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/16214
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/16275
Submitter: Sarin Kizhakkepurayil (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/16275
Committed: http://github.org/Juniper/contrail-web-core/commit/e9b4ab0300623de58aecaea4e9bdc97b1380199a
Submitter: Zuul
Branch: master

commit e9b4ab0300623de58aecaea4e9bdc97b1380199a
Author: Sarin Kizhakkepurayil <email address hidden>
Date: Wed Jan 13 15:47:21 2016 -0800

Related-Bug: #1532666 re-use existing contentHandler

- adding support for multiple load of layoutHandler.
when layoutHandler is reloaded, we need to reuse the existing contentHandler instance

Change-Id: I960d63525abb687e0563cf9b7b6116f49269e2b3

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/16214
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/17063
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22.x

Review in progress for https://review.opencontrail.org/17064
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/16214
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22.x

Review in progress for https://review.opencontrail.org/17064
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/17063
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22.x

Review in progress for https://review.opencontrail.org/17064
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/17063
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/16214
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22.x

Review in progress for https://review.opencontrail.org/17064
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/17063
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/17064
Committed: http://github.org/Juniper/contrail-web-core/commit/25751c35613747724cf2b34e0f4f8d7171b4ed62
Submitter: Zuul
Branch: R2.22.x

commit 25751c35613747724cf2b34e0f4f8d7171b4ed62
Author: Biswajit Mandal <email address hidden>
Date: Mon Jan 11 23:28:02 2016 +0530

Related-Bug: #1532666
1. Earlier we used to allow only admin role users, due to which we had to get
all the roles per project while log-in, if there are a lot of projects for this
user, then it used to take lot of time to get this info, so login time was more.
2. Corrected the hash value of mon_net_dashboard -> mon_networking_dashboard
3. But still in R2.20 it is not advised to login using member role, only admin
role, as this is only not to burden keystone while login with all tenant
role-get. API Server thorws permission denied in r2.20 for non-admin role
projects.

Conflicts:
 src/serverroot/common/auth.api.js
 src/serverroot/orchestration/plugins/cloudstack/cloudstack.authApi.js
 src/serverroot/orchestration/plugins/no-orch/noOrchestration.api.js
 src/serverroot/orchestration/plugins/openstack/keystone.api.js
 src/serverroot/orchestration/plugins/vcenter/vcenter.authApi.js
 webroot/js/handlers/ContentHandler.js
 webroot/js/handlers/LayoutHandler.js

Change-Id: I07263eeef23e028740f2b9edfa6e34ac28e49362

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/16214
Committed: http://github.org/Juniper/contrail-web-core/commit/69f45dd81fdc09532e331cf3f1d8d537b273d255
Submitter: Zuul
Branch: master

commit 69f45dd81fdc09532e331cf3f1d8d537b273d255
Author: Biswajit Mandal <email address hidden>
Date: Mon Jan 11 23:28:02 2016 +0530

Related-Bug: #1532666
1. Allow member role users also to login.
2. Earlier we used to allow only admin role users, due to which we had to get
all the roles per project while log-in, if there are a lot of projects for this
user, then it used to take lot of time to get this info, so login time was more.
3. Once log-in if the user has member role for this project set in cookie, then
some menu itesm will be disabled, only switching to admin project from config
page, the menu will get enabled, it is same as horizon behavior.
4. Corrected the hash value of mon_net_dashboard -> mon_networking_dashboard

Change-Id: I07263eeef23e028740f2b9edfa6e34ac28e49362

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/17063
Committed: http://github.org/Juniper/contrail-web-core/commit/27fc201f2114f4a8da408b1921f467798e69b79e
Submitter: Zuul
Branch: R2.20

commit 27fc201f2114f4a8da408b1921f467798e69b79e
Author: Biswajit Mandal <email address hidden>
Date: Mon Jan 11 23:28:02 2016 +0530

Related-Bug: #1532666
1. Earlier we used to allow only admin role users, due to which we had to get
all the roles per project while log-in, if there are a lot of projects for this
user, then it used to take lot of time to get this info, so login time was more.
2. Corrected the hash value of mon_net_dashboard -> mon_networking_dashboard
3. But still in R2.20 it is not advised to login using member role, only admin
role, as this is only not to burden keystone while login with all tenant
role-get. API Server thorws permission denied in r2.20 for non-admin role
projects.

Conflicts:
 src/serverroot/common/auth.api.js
 src/serverroot/orchestration/plugins/cloudstack/cloudstack.authApi.js
 src/serverroot/orchestration/plugins/no-orch/noOrchestration.api.js
 src/serverroot/orchestration/plugins/openstack/keystone.api.js
 src/serverroot/orchestration/plugins/vcenter/vcenter.authApi.js
 webroot/js/handlers/ContentHandler.js
 webroot/js/handlers/LayoutHandler.js

Change-Id: I07263eeef23e028740f2b9edfa6e34ac28e49362

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/17148
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22.x

Review in progress for https://review.opencontrail.org/17149
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/17148
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/17158
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.21.x

Review in progress for https://review.opencontrail.org/17167
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22.x

Review in progress for https://review.opencontrail.org/17149
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/17148
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.21.x

Review in progress for https://review.opencontrail.org/17167
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22.x

Review in progress for https://review.opencontrail.org/17149
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.21.x

Review in progress for https://review.opencontrail.org/17167
Submitter: Biswajit Mandal (<email address hidden>)

Rahul (rahuls)
description: updated
summary: - [UI] Allow member role to login
+ [UI] Don't check admin role for all tenants at login
information type: Proprietary → Public
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.