OpenStack Dashboard (Horizon)

Some panels is not set proper policy rules

Bug #1534495 reported by Kenji Ishii on 2016-01-15

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	High	Unassigned	OpenStack Dashboard (Horizon) queens-1

Bug Description

Panels listing of below are not set proper policy rules. These are only set a permission of service.
Therefore if service is enable but a user don't have a privilege by policy.json, a user will be able to display its page but an API error will occur.
I think we should address it like a "projects" panel.

openstack_dashboard/dashboards/admin/aggregates/panel.py
openstack_dashboard/dashboards/admin/defaults/panel.py
openstack_dashboard/dashboards/admin/flavors/panel.py
openstack_dashboard/dashboards/admin/hypervisors/panel.py
openstack_dashboard/dashboards/admin/images/panel.py
openstack_dashboard/dashboards/admin/info/panel.py
openstack_dashboard/dashboards/admin/instances/panel.py
openstack_dashboard/dashboards/admin/metadata_defs/panel.py
openstack_dashboard/dashboards/admin/networks/panel.py
openstack_dashboard/dashboards/admin/routers/panel.py
openstack_dashboard/dashboards/admin/volumes/panel.py
openstack_dashboard/dashboards/project/access_and_security/panel.py
openstack_dashboard/dashboards/project/firewalls/panel.py
openstack_dashboard/dashboards/project/images/panel.py
openstack_dashboard/dashboards/project/instances/panel.py
openstack_dashboard/dashboards/project/loadbalancers/panel.py
openstack_dashboard/dashboards/project/network_topology/panel.py
openstack_dashboard/dashboards/project/networks/panel.py
openstack_dashboard/dashboards/project/ngimages/panel.py
openstack_dashboard/dashboards/project/overview/panel.py
openstack_dashboard/dashboards/project/routers/panel.py
openstack_dashboard/dashboards/project/stacks/panel.py
openstack_dashboard/dashboards/project/stacks/resource_types/panel.py

Tags:

Kenji Ishii (ken-ishii) on 2016-01-15

Changed in horizon:
assignee:	nobody → Kenji Ishii (ken-ishii)

Revision history for this message

Rob Cresswell (robcresswell-deactivatedaccount) wrote on 2016-03-23:

Removed assignee due to inactivity.

Changed in horizon:
importance:	Undecided → High
status:	New → Confirmed
milestone:	none → ongoing
assignee:	Kenji Ishii (ken-ishii) → nobody
tags:	added: low-hanging-fruit

Revision history for this message

Rob Cresswell (robcresswell-deactivatedaccount) wrote on 2016-03-23:

Marked as low-hanging-fruit. Although this sounds like a complex issue, it mostly just means adding policy_rules values to existing code, referencing the policy files in `openstack_dashboard/conf`. You can read more about policy here: http://docs.openstack.org/developer/horizon/topics/policy.html

Rob Cresswell (robcresswell-deactivatedaccount) on 2016-03-31

Changed in horizon:
milestone:	ongoing → next

Raquel Lira (raquel-lira) on 2016-04-07

Changed in horizon:
assignee:	nobody → Raquel Lira (raquel-lira)

Raquel Lira (raquel-lira) on 2016-04-25

Changed in horizon:
assignee:	Raquel Lira (raquel-lira) → nobody

Raquel Lira (raquel-lira) on 2016-04-26

Changed in horizon:
assignee:	nobody → Raquel Lira (raquel-lira)

Revision history for this message

Janki Chhatbar (jankihchhatbar) wrote on 2016-05-11:

Raquel Lira, are you working on this bug? If not, I would like to take it up.

Thanks
Janki

Raquel Lira (raquel-lira) on 2016-06-22

Changed in horizon:
assignee:	Raquel Lira (raquel-lira) → nobody

Kranthi Dhanala (kranthi-dhanala92) on 2016-07-25

Changed in horizon:
assignee:	nobody → Kranthi Dhanala (kranthi-dhanala92)

Kranthi Dhanala (kranthi-dhanala92) on 2016-08-05

Changed in horizon:
assignee:	Kranthi Dhanala (kranthi-dhanala92) → nobody

Sharat Sharma (sharat-sharma) on 2016-08-09

Changed in horizon:
assignee:	nobody → Sharat Sharma (sharat-sharma)

Revision history for this message

Rob Cresswell (robcresswell-deactivatedaccount) wrote on 2016-09-20:

Removed assignee, it's been ~6 weeks without a patch.

Changed in horizon:
assignee:	Sharat Sharma (sharat-sharma) → Rob Cresswell (robcresswell)

Revision history for this message

Sharat Sharma (sharat-sharma) wrote on 2016-09-20:

Sorry! I totally forgot about this patch :(

Laurent Baeriswyl (lbaeriswyl) on 2016-10-04

Changed in horizon:
assignee:	Rob Cresswell (robcresswell) → Laurent Baeriswyl (lbaeriswyl)

OpenStack Infra (hudson-openstack) on 2016-10-06

Changed in horizon:
assignee:	Laurent Baeriswyl (lbaeriswyl) → Calvin Rutley (crutley)
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-07: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/383937

Changed in horizon:
assignee:	Calvin Rutley (crutley) → Laurent Baeriswyl (lbaeriswyl)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-20:

Fix proposed to branch: master
Review: https://review.openstack.org/389361

Changed in horizon:
assignee:	Laurent Baeriswyl (lbaeriswyl) → Calvin Rutley (crutley)

OpenStack Infra (hudson-openstack) on 2016-10-26

Changed in horizon:
assignee:	Calvin Rutley (crutley) → Laurent Baeriswyl (lbaeriswyl)

OpenStack Infra (hudson-openstack) on 2016-10-26

Changed in horizon:
assignee:	Laurent Baeriswyl (lbaeriswyl) → Calvin Rutley (crutley)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-31: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/389361
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3a56958bd3c6e104e7690886965eb563b15d456d
Submitter: Jenkins
Branch: master

commit 3a56958bd3c6e104e7690886965eb563b15d456d
Author: Calvin <email address hidden>
Date: Tue Oct 11 15:12:43 2016 -0700

Adds Policy Rules to Project Images panel

Currently the panel is missing appropriate poilcy rules
This patch adds the rules

Change-Id: I4fa8d588cd4a57ecb0cef935dc5544d2b012aeb3
Partial-bug:#1534495

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-31:

Reviewed: https://review.openstack.org/388949
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a4af4e086681c51718c29ae401b10d45eac10321
Submitter: Jenkins
Branch: master

commit a4af4e086681c51718c29ae401b10d45eac10321
Author: Laurent Baeriswyl <email address hidden>
Date: Wed Oct 19 18:04:03 2016 -0700

Add appropriate policy rules to admin images panel

Currently many panels are missing appropriate policy rules.

This patch adds policy rules to the admin images panel.

Change-Id: I8b25b420417387ef1d0ede1169243e30da343067
Partial-bug:#1534495

Rob Cresswell (robcresswell-deactivatedaccount) on 2016-11-01

tags:

added: newton-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-01: Fix proposed to horizon (stable/newton)

#10

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/392070

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-01:

#11

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/392072

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-02: Fix merged to horizon (stable/newton)

#12

Reviewed: https://review.openstack.org/392070
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8d536a5e9cea9cc7f06be47835bdd69b93a79ebe
Submitter: Jenkins
Branch: stable/newton

commit 8d536a5e9cea9cc7f06be47835bdd69b93a79ebe
Author: Calvin <email address hidden>
Date: Tue Oct 11 15:12:43 2016 -0700

Adds Policy Rules to Project Images panel

Currently the panel is missing appropriate poilcy rules
This patch adds the rules

    Change-Id: I4fa8d588cd4a57ecb0cef935dc5544d2b012aeb3
    Partial-bug:#1534495
    (cherry picked from commit 3a56958bd3c6e104e7690886965eb563b15d456d)

tags:

added: in-stable-newton

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-02:

#13

Reviewed: https://review.openstack.org/392072
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1347d4d22c5b7aeec4bb3a377637dc0e19876838
Submitter: Jenkins
Branch: stable/newton

commit 1347d4d22c5b7aeec4bb3a377637dc0e19876838
Author: Laurent Baeriswyl <email address hidden>
Date: Wed Oct 19 18:04:03 2016 -0700

Add appropriate policy rules to admin images panel

Currently many panels are missing appropriate policy rules.

This patch adds policy rules to the admin images panel.

    Change-Id: I8b25b420417387ef1d0ede1169243e30da343067
    Partial-bug:#1534495
    (cherry picked from commit a4af4e086681c51718c29ae401b10d45eac10321)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-22: Fix proposed to horizon (master)

#14

Fix proposed to branch: master
Review: https://review.openstack.org/414315

Changed in horizon:
assignee:	Calvin Rutley (crutley) → Samantha Blanco (sblanco1)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-03: Fix merged to horizon (master)

#15

Reviewed: https://review.openstack.org/414315
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=59741bd46ebd7b6570892dad394aad6c8b7cc990
Submitter: Jenkins
Branch: master

commit 59741bd46ebd7b6570892dad394aad6c8b7cc990
Author: Samantha Blanco <email address hidden>
Date: Thu Dec 22 14:32:55 2016 -0500

Add policy rules to project panels

    Add policy rules to panel in
    - firewalls
    - instances
    - network_topology
    - networks
    - routers
    - stacks

Change-Id: Iab9f2ebb9f70febbc712eb4cfacf069049db7426
Partial-Bug:#1534495

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-17: Change abandoned on horizon (master)

#16

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/383937
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-05-18:

#17

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/383186
Reason: Abandoned due to inactivity

Akihiro Motoki (amotoki) on 2017-08-16

Changed in horizon:
assignee:	Samantha Blanco (sblanco1) → nobody

Revision history for this message

David Lyle (david-lyle) wrote on 2017-09-11:

#18

This was addressed by https://github.com/openstack/horizon/commit/43e9df85ab286ddee96e9cff97f551781baf70d1

Changed in horizon:
status:	In Progress → Fix Released

Akihiro Motoki (amotoki) on 2017-09-20

Changed in horizon:
milestone:	next → none

Akihiro Motoki (amotoki) on 2017-10-24

Changed in horizon:
milestone:	none → queens-1

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.