udev: 56-hpmud.rules should not run usb_id for all USB devices out there

Bug #1537467 reported by Ivan Shapovalov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HPLIP
Fix Released
Undecided
Unassigned
hplip (Arch Linux)
New
Undecided
Unassigned

Bug Description

The pre-history could be seen in this issue first reported to systemd/udev: https://github.com/systemd/systemd/issues/2414

In short, the HPLIP's `56-hpmud.rules` udev rules file runs `usb_id` unconditionally for all USB devices (but only on "add" event), which 1) affects execution of follow-up rules and 2) makes the whole process yield different results on "add" and "change" events.

Ultimately, this leads to unexpectedly changing attributes and device node symlinks for USB-ATA disk devices (completely unrelated to HPLIP) after a "change" event.

Observing the rule file itself, I suspect that a GOTO to rule file end is missing:

--- a/56-hpmud.rules 2015-12-07 04:28:15.000000000 +0300
+++ b/56-hpmud.rules 2016-01-24 12:32:24.708201975 +0300
@@ -3,6 +3,7 @@
 ACTION!="add", GOTO="hpmud_rules_end"
 SUBSYSTEM=="ppdev", OWNER="root", GROUP="lp", MODE="0664"
 SUBSYSTEM=="usb", ENV{DEVTYPE}=="usb_device", GOTO="hpmud_usb_rules"
+GOTO="hpmud_rules_end"

 LABEL="hpmud_usb_rules"

Tags: udev
Revision history for this message
Sanjay Kumar (sanjay-kumar14) wrote :

Hi Ivan,

Thanks for reporting this issue. We will look into this and provide the fix in future HPLIP versions.

Changed in hplip:
status: New → Fix Committed
Revision history for this message
Sanjay Kumar (sanjay-kumar14) wrote :

Fixed in hplip-3.16.2

Changed in hplip:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.