Fuel for OpenStack

3 reset_environment tasks in cluster after it has been reset

Bug #1541868 reported by Julia Aranovich on 2016-02-04

This bug affects 6 people

	Status	Importance	Assigned to	Milestone
Fuel for OpenStack	Fix Committed	High	Anastasia Balobashina	Fuel for OpenStack 11.0
Mitaka	Fix Released	High	Anastasia Balobashina	Fuel for OpenStack 9.2
Newton	Fix Released	High	Anastasia Balobashina	Fuel for OpenStack 10.1
Ocata	Fix Committed	High	Anastasia Balobashina	Fuel for OpenStack 11.0

Bug Description

Reproduced on fake ui:

1) Deploy default environment with 1 controller
2) Reset deployment

Expected result: there is one 'reset_deployment' task in GET /api/tasks?cluster_id=1 response
Actual result: there is 3 'reset_deployment' tasks in GET /api/tasks?cluster_id=1 response:

[{"status": "ready", "name": "reset_environment", "cluster": 1, "result": {}, "progress": 100, "message": "Environment '1' was successfully reset", "id": 8, "uuid": "fb208843-971f-46cd-8436-f4ccc9ab6b5a"}, {"status": "ready", "name": "reset_environment", "cluster": 1, "result": {}, "progress": 100, "message": "Environment '1' was successfully reset\nEnvironment '1' was successfully reset", "id": 7, "uuid": "7cfc9eef-6670-4fd3-accd-b128e2ba9b52"}, {"status": "ready", "name": "reset_environment", "cluster": 1, "result": {}, "progress": 100, "message": "Environment '1' was successfully reset", "id": 9, "uuid": "78cac574-61d3-4397-a7dc-3839157e695a"}]

And one of the has double message: "Environment '1' was successfully reset\nEnvironment '1' was successfully reset"

Please consider also an attached screenshot of Fuel UI.

Tags:

Revision history for this message

Julia Aranovich (jkirnosova) wrote on 2016-02-04:

Screenshot from 2016-02-04 17:11:33.png Edit (130.7 KiB, image/png)

Matthew Mosesohn (raytrac3r) on 2016-02-05

Changed in fuel:
status:	New → Confirmed
importance:	Undecided → Medium
tags:	added: team-bugfixx

Vitaly Kramskikh (vkramskikh) on 2016-02-05

tags:

added: team-bugfix
removed: team-bugfixx

Revision history for this message

Dmitry Pyzhov (dpyzhov) wrote on 2016-02-15:

We have a strong rule not to backport Medium priority bugs.

Dmitry Pyzhov (dpyzhov) on 2016-03-02

tags:

added: feature-reset-env

Revision history for this message

Dmitry Pyzhov (dpyzhov) wrote on 2016-03-28:

Please remove tech-debt tag if you see this bug on live environment.

tags:	added: fake-ui tech-debt
no longer affects:	fuel/mitaka
no longer affects:	fuel/8.0.x
Changed in fuel:
milestone:	9.0 → 10.0

Revision history for this message

Julia Aranovich (jkirnosova) wrote on 2016-05-26:

Suggest to increase the issue priority. We start to get more complaints about it: https://bugs.launchpad.net/fuel/+bug/1585631

Changed in fuel:
importance:	Low → Medium

Dmitry Pyzhov (dpyzhov) on 2016-06-22

Changed in fuel:
assignee:	Fuel Python (Deprecated) (fuel-python) → Fuel Sustaining (fuel-sustaining-team)

Revision history for this message

Vitalii Kulanov (vitaliy-t) wrote on 2016-07-07:

Related bug https://bugs.launchpad.net/fuel/+bug/1579478

Revision history for this message

Julia Aranovich (jkirnosova) wrote on 2016-08-18:

The issue is reproducable on live environment.

tags:

removed: fake-ui tech-debt ui

Revision history for this message

Julia Aranovich (jkirnosova) wrote on 2016-08-18:

Please pay attention to a number of duplicated for this ticket. It shows that user is really affected by the bug.

Vladimir Kuklin (vkuklin) on 2016-12-15

Changed in fuel:
importance:	Medium → High

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-23: Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/414470

Changed in fuel:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-13: Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/419825

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-13: Fix proposed to fuel-web (stable/newton)

#10

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/419834

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-13: Fix merged to fuel-web (master)

#11

Reviewed: https://review.openstack.org/414470
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=93f40003deefcffdc80d85f95eb064eea15291e6
Submitter: Jenkins
Branch: master

commit 93f40003deefcffdc80d85f95eb064eea15291e6
Author: Anastasiya <email address hidden>
Date: Thu Dec 22 18:33:05 2016 +0400

Fix naming of reset tasks and message duplication

    * reset_environment supertask contains 3 subtasks:
      base_reset_environment, remove_keys_task,
      remove_ironic_bootstrap_task
    * names for tasks were changed
    * response methods for remove_keys_task and
      remove_ironic_bootstrap_task were added to receiver
    * _restore_pending_changes method was add only for
      reset_environment_resp
    * migration for adding new transaction names and appropriate
      test were added
    * test for check task message was added

Change-Id: Ib8a215174431486316bca533797932e02969c037
Closes-Bug: #1541868

Changed in fuel:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-13: Fix merged to fuel-web (stable/newton)

#12

Reviewed: https://review.openstack.org/419834
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=9cf3caee4dd2719aa1385f984ef511e767dd6a55
Submitter: Jenkins
Branch: stable/newton

commit 9cf3caee4dd2719aa1385f984ef511e767dd6a55
Author: Anastasiya <email address hidden>
Date: Thu Dec 22 18:33:05 2016 +0400

Fix naming of reset tasks and message duplication

    Change-Id: Ib8a215174431486316bca533797932e02969c037
    Closes-Bug: #1541868
    (cherry picked from commit 93f40003deefcffdc80d85f95eb064eea15291e6)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-01-13: Fix merged to fuel-web (stable/mitaka)

#13

Reviewed: https://review.openstack.org/419825
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=bad8f4385732fdfa1a8f794fe2030ab744c0090a
Submitter: Jenkins
Branch: stable/mitaka

commit bad8f4385732fdfa1a8f794fe2030ab744c0090a
Author: Anastasiya <email address hidden>
Date: Thu Dec 22 18:33:05 2016 +0400

Fix naming of reset tasks and message duplication

    Change-Id: Ib8a215174431486316bca533797932e02969c037
    Closes-Bug: #1541868
    (cherry picked from commit 93f40003deefcffdc80d85f95eb064eea15291e6)

Ekaterina Shutova (eshutova) on 2017-01-13

tags:

added: on-verification

Revision history for this message

Ekaterina Shutova (eshutova) wrote on 2017-01-17:

#14

Verified on 9.2 snapshot #770.
New subtasks added in reset_environment task, no double message anymore after reset, all tasks are in a single copy in GET request.

tags:

removed: on-verification

Revision history for this message

Ekaterina Shutova (eshutova) wrote on 2017-02-14:

#15

8.0 + mu4 updates is also affected:
* Connection #0 to host 10.109.5.2 left intact
[{"status": "ready", "name": "reset_environment", "cluster": 1, "result": {}, "progress": 100, "message": "Environment 'lvi' was successfully reset\nEnvironment 'lvi' was successfully reset", "id": 4, "uuid": "6a301141-4a85-4b8b-a56e-828dc9ec9619"}, {"status": "ready", "name": "reset_environment", "cluster": 1, "result": {}, "progress": 100, "message": "Environment 'lvi' was successfully reset", "id": 6, "uuid": "9390ecd1-c8f7-4c1b-b257-ff6c8cb77084"}, {"status": "ready", "name": "reset_environment", "cluster": 1, "result": {}, "progress": 100, "message": "Environment 'lvi' was successfully reset", "id": 5, "uuid": "bcc78dd6-ef35-41a0-b586-5fbc7578616d"}][root@nailgun ~]#