python-muranoclient

[cli] create commands should show newly created objects, not list all the objects

Bug #1544748 reported by Kirill Zaitsev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-muranoclient
Fix Released
Medium
Jacek Tomasiak
python-muranoclient 0.8.2

Bug Description

It doesn't make sense to list anything, but the newly created package/environment after creation.

Besides, that's what most openstack clients do

glance: https://github.com/openstack/python-glanceclient/blob/a49ce80db6662a3275ba504cd667723e6638cd62/glanceclient/v2/shell.py#L87
nova: https://github.com/openstack/python-novaclient/blob/99c588e28c2c4eb0b684cfd54d79d76fc30197fe/novaclient/v2/shell.py#L830 (note it only lists currently created flavor)

Revision history for this message
Jacek Tomasiak (skazi) wrote :

What about import operations (e.g. package-import)? IMHO it should also show only the new package. What do you think?

Changed in python-muranoclient:
assignee: nobody → Jacek Tomasiak (skazi)
Revision history for this message
Jacek Tomasiak (skazi) wrote :

I checked novaclient and it does limited listing even for "delete" operations (i.e. shows a table with deleted flavor after deleting it). Should we align murano-client with other clients for all operations?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-muranoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/280023

Changed in python-muranoclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (master)

Reviewed: https://review.openstack.org/280023
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=a4ef62e8b00caab69244bfdc6623c867c622951b
Submitter: Jenkins
Branch: master

commit a4ef62e8b00caab69244bfdc6623c867c622951b
Author: Jacek Tomasiak <email address hidden>
Date: Sun Feb 14 21:33:07 2016 +0100

    Make CLI outputs consistent with other OpenStack clients

    Murano-client CLI prints out full list of items as a result of most
    operations (e.g. create operation display list of all existing items
    instead of just the created one).

    This change is an attempt to make this behaviour consistent with other
    clients (e.g. nova-client) which print out only items relevant to the
    performed operation. Following rules were implemented:
    - create/import operations display only items actually created/imported
    - delete operations list of items after delete
    - update/rename operations show only updated items (after update)

    Change-Id: I14b0b310c4495255aeb6058851ec4db07fec3af5
    Closes-Bug: #1544748

Changed in python-muranoclient:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.