Mirantis OpenStack

django-compressor==2.0 requires Django 1.8 to work

Bug #1545692 reported by Rodion Tikunov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mirantis OpenStack
Fix Released
High
MOS Maintenance
Mirantis OpenStack 8.0-updates
7.0.x
Fix Released
High
Rodion Tikunov
Mirantis OpenStack 7.0-mu-3
8.0.x
Won't Fix
High
MOS Maintenance
Mirantis OpenStack 8.0-updates
9.x
Fix Released
High
Daniil Trishkin
Mirantis OpenStack 9.0

Bug Description

Confirmed on:
MOS 7.0

Issue:
CI tests gate-horizon-pep8 and gate-horizon-python27 for the horizon failed up with "ImportError: No module named utils" message.
Looks like this is probably due to django_compressor 2.0 released breaking this:
https://pypi.python.org/pypi/django_compressor/2.0

Details:
14:14:44 pep8 runtests: commands[1] | /bin/bash run_tests.sh -N --makemessages --check-only
14:14:44 /home/jenkins/workspace/gate-horizon-pep8$ /bin/bash run_tests.sh -N --makemessages --check-only
14:14:44 horizon: Traceback (most recent call last):
14:14:44 File "/home/jenkins/workspace/gate-horizon-pep8/manage.py", line 23, in <module>
14:14:44 execute_from_command_line(sys.argv)
14:14:44 File "/home/jenkins/workspace/gate-horizon-pep8/.tox/pep8/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 385, in execute_from_command_line
14:14:44 utility.execute()
14:14:44 File "/home/jenkins/workspace/gate-horizon-pep8/.tox/pep8/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 354, in execute
14:14:44 django.setup()
14:14:44 File "/home/jenkins/workspace/gate-horizon-pep8/.tox/pep8/local/lib/python2.7/site-packages/django/__init__.py", line 21, in setup
14:14:44 apps.populate(settings.INSTALLED_APPS)
14:14:44 File "/home/jenkins/workspace/gate-horizon-pep8/.tox/pep8/local/lib/python2.7/site-packages/django/apps/registry.py", line 108, in populate
14:14:44 app_config.import_models(all_models)
14:14:44 File "/home/jenkins/workspace/gate-horizon-pep8/.tox/pep8/local/lib/python2.7/site-packages/django/apps/config.py", line 202, in import_models
14:14:44 self.models_module = import_module(models_module_name)
14:14:44 File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
14:14:44 __import__(name)
14:14:44 File "/home/jenkins/workspace/gate-horizon-pep8/.tox/pep8/local/lib/python2.7/site-packages/compressor/models.py", line 1, in <module>
14:14:44 from compressor.conf import CompressorConf # noqa
14:14:44 File "/home/jenkins/workspace/gate-horizon-pep8/.tox/pep8/local/lib/python2.7/site-packages/compressor/conf.py", line 5, in <module>
14:14:44 from django.template.utils import InvalidTemplateEngineError
14:14:44 ImportError: No module named utils

http://logs.mosi.mirantis.net/22/16722/2/check/gate-horizon-pep8/e615f20/console.html.gz

Rodion Tikunov (rtikunov)
Changed in mos:
assignee: nobody → Rodion Tikunov (rtikunov)
assignee: Rodion Tikunov (rtikunov) → nobody
status: New → Confirmed
Revision history for this message
Roman Podoliaka (rpodolyaka) wrote :

MOS Horizon team, please check if 7.0-updates CI is affected. We should either add a cap to mos-requirements repo or merge a fix to Horizon (if there was one to stable/kilo branch in upstream).

Changed in mos:
assignee: nobody → MOS Horizon (mos-horizon)
milestone: none → 7.0-updates
importance: Undecided → High
tags: added: area-horizon
removed: horizon
Rodion Tikunov (rtikunov)
Changed in mos:
assignee: MOS Horizon (mos-horizon) → Rodion Tikunov (rtikunov)
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to openstack/horizon (openstack-ci/fuel-7.0/2015.1.0)

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: OpenStack Proposal Bot <email address hidden>
Review: https://review.fuel-infra.org/17044

Changed in mos:
status: Confirmed → In Progress
Revision history for this message
Timur Sufiev (tsufiev-x) wrote : Re: CI tests failed up for horizon with "ImportError: No module named utils" message

Guys, here's is the root cause: Django 1.7 which is used in 7.0 has reached EOL with the release of Django 1.9. We should either migrate to Django 1.8 ASAP, or if current release policies prohibit it (I strongly suspect so), introduce upper caps on every Django-related package we use. django-compressor==2.0, for example, already discards Django 1.7 as a supported Django version and needs Django 1.8 to run.

Timur Sufiev (tsufiev-x)
summary: - CI tests failed up for horizon with "ImportError: No module named utils"
- message
+ django-compressor==2.0 requires Django 1.8 to work
Rodion Tikunov (rtikunov)
Changed in mos:
assignee: Rodion Tikunov (rtikunov) → nobody
status: In Progress → Confirmed
Revision history for this message
Roman Podoliaka (rpodolyaka) wrote :

Timur, let's do a patch to mos-requirements similar to

https://review.fuel-infra.org/#/c/16885/

Changed in mos:
assignee: nobody → Timur Sufiev (tsufiev-x)
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to mos-infra/mos-requirements (master)

Fix proposed to branch: master
Change author: Timur Sufiev <email address hidden>
Review: https://review.fuel-infra.org/17077

Revision history for this message
Roman Podoliaka (rpodolyaka) wrote :

I talked with Timur and there are 2 different problems here:

1) tests are broken due to a missing cap on django-compressor - we are going to fix it by proposing a change to mos-requirements

2) we are using outdated django version - we should really consider updating django to 1.8 in 8.0-MU1, as there will be no security updates for 1.7

tags: added: move-to-mu
Revision history for this message
Roman Podoliaka (rpodolyaka) wrote :

Marking 9.0 as affected, so that we don't forget to upgrade django there.

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote :

Fix proposed to branch: master
Change author: Rodion Tikunov <email address hidden>
Review: https://review.fuel-infra.org/17089

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to openstack/horizon (openstack-ci/fuel-7.0/2015.1.0)

Reviewed: https://review.fuel-infra.org/17044
Submitter: Denis V. Meltsaykin <email address hidden>
Branch: openstack-ci/fuel-7.0/2015.1.0

Commit: 699994a57ecf2a56a168e6fbc545c5c7bc471ddb
Author: OpenStack Proposal Bot <email address hidden>
Date: Mon Feb 15 12:38:35 2016

Updated from global requirements and workaround testr/pbr issue

The fix for pbr is in 6e472b4905411a39e993c81c382a27ca9c771ef5 but
rather than wait for that to be released in pbr on stable/kilo we
will workaround it here so we can get stable/kilo and stable/liberty
gates unblocked, then come back and cleanup later.

Closes-Bug: #1545692

Conflicts:
 requirements.txt

Change-Id: I59a128a1775ac06c2ca5f53ced9e1eaeb2f3f889
(cherry picked from commit 03c154b0bba5b88a45f352388faf8e17a3b341c4)

Revision history for this message
Timur Sufiev (tsufiev-x) wrote :

Guys, we need to switch to django-compressor>=2.0 and Django==1.8.

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix proposed to packages/trusty/python-django-compressor (master)

Related fix proposed to branch: master
Change author: Daniil Trishkin <email address hidden>
Review: https://review.fuel-infra.org/18032

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/trusty/python-coffin (master)

Fix proposed to branch: master
Change author: Daniil Trishkin <email address hidden>
Review: https://review.fuel-infra.org/18035

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to fuel-infra/jeepyb-config (master)

Fix proposed to branch: master
Change author: Daniil Trishkin <email address hidden>
Review: https://review.fuel-infra.org/18040

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/trusty/python-coffin (master)

Reviewed: https://review.fuel-infra.org/18035
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: 1fa910b8ef640f5325c01fb65a0459fc1698e5c2
Author: Daniil Trishkin <email address hidden>
Date: Mon Mar 14 15:29:48 2016

Update to 2.0.1

 * Update runtime requirements according to global requirements of Mitaka
 * Sources are from
   http://http.debian.net/debian/pool/main/p/python-coffin/python-coffin_2.0.1-1.dsc
 * Add patch for relative import in py3

Change-Id: I1a03421b0dcd72c38fd46dc7b71ac9d4c2604ad2
Partial-Bug: #1545692

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to fuel-infra/jeepyb-config (master)

Reviewed: https://review.fuel-infra.org/18040
Submitter: Igor Shishkin <email address hidden>
Branch: master

Commit: 3ab72e302c5317da6c6cdd6cd60f70b51576d9c1
Author: Daniil Trishkin <email address hidden>
Date: Mon Mar 14 18:38:49 2016

Added projects:

 * packages/trusty/python-csscompressor
 * packages/trusty/python-django-overextends
 * packages/trusty/django-sekizai
 * packages/trusty/python-rcssmin
 * packages/trusty/python-rjsmin

as dependencies of python-django-compressor

Change-Id: I1f04ad56cb9dda325d9dab9510f76df3cb593426
Partial-Bug: #1545692

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/trusty/django-sekizai (master)

Fix proposed to branch: master
Change author: Daniil Trishkin <email address hidden>
Review: https://review.fuel-infra.org/18108

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/trusty/python-csscompressor (master)

Fix proposed to branch: master
Change author: Daniil Trishkin <email address hidden>
Review: https://review.fuel-infra.org/18109

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/trusty/python-django-overextends (master)

Fix proposed to branch: master
Change author: Daniil Trishkin <email address hidden>
Review: https://review.fuel-infra.org/18111

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/trusty/python-rcssmin (master)

Fix proposed to branch: master
Change author: Daniil Trishkin <email address hidden>
Review: https://review.fuel-infra.org/18114

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/trusty/python-rjsmin (master)

Fix proposed to branch: master
Change author: Daniil Trishkin <email address hidden>
Review: https://review.fuel-infra.org/18115

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to packages/trusty/pep8 (master)

Fix proposed to branch: master
Change author: Daniil Trishkin <email address hidden>
Review: https://review.fuel-infra.org/18123

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix proposed to fuel-infra/jeepyb-config (master)

Related fix proposed to branch: master
Change author: Daniil Trishkin <email address hidden>
Review: https://review.fuel-infra.org/18125

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix merged to fuel-infra/jeepyb-config (master)

Reviewed: https://review.fuel-infra.org/18125
Submitter: Andrey Nikitin <email address hidden>
Branch: master

Commit: 07987ed56d5c42570d9d7db43fc89a07cadce342
Author: Daniil Trishkin <email address hidden>
Date: Wed Mar 16 15:09:09 2016

Added project

 * packages/trusty/django-classy-tags

as build dependency of django-sekizai

Change-Id: Ie02e8de067dccdceaef94be065f269c788a8f16e
Related-Bug: #1545692

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/trusty/python-csscompressor (master)

Reviewed: https://review.fuel-infra.org/18109
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: 511dfcca56381d0e362ba28561c7ce9deff9bf4f
Author: Daniil Trishkin <email address hidden>
Date: Tue Mar 15 16:13:05 2016

Add python-csscompressor 0.9.4

  * Sources are from
    http://http.debian.net/debian/pool/main/p/python-csscompressor/python-csscompressor_0.9.4-2.dsc
  * Update runtime requirements according to global requirements of Mitaka

Change-Id: I702de71965d20356700e634774795c194dc6b4c9
Partial-Bug: #1545692

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/trusty/python-rjsmin (master)

Reviewed: https://review.fuel-infra.org/18115
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: 3cfef7506e21e599d5f8ef9c633379ae1940665e
Author: Daniil Trishkin <email address hidden>
Date: Tue Mar 15 16:22:58 2016

Add python-rjsmin 1.0.12

  * Sources are from
    http://http.debian.net/debian/pool/main/p/python-rjsmin/python-rjsmin_1.0.12+dfsg1-2.dsc
  * Update runtime requirements according to global requirements of Mitaka

Change-Id: I3efd12c5fecd2ecacc2ec7373e05b8567de6d3b4
Partial-Bug: #1545692

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/trusty/python-rcssmin (master)

Reviewed: https://review.fuel-infra.org/18114
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: 82696ab79907f8e2dcce424565d3693db39a74a7
Author: Daniil Trishkin <email address hidden>
Date: Tue Mar 15 16:22:17 2016

Add python-rcssmin 1.0.6

  * Sources are from
    http://http.debian.net/debian/pool/main/p/python-rcssmin/python-rcssmin_1.0.6-1.dsc
  * Update runtime requirements according to global requirements of Mitaka

Change-Id: I8ba6ffa92de8d80d35896a01702e3b5dcdd1e208
Partial-Bug: #1545692

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/trusty/python-django-overextends (master)

Reviewed: https://review.fuel-infra.org/18111
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: 01f5df2223b5ed942f01ef4f7d17fe10974bb44a
Author: Daniil Trishkin <email address hidden>
Date: Tue Mar 15 16:50:23 2016

Add python-django-overextends 0.4.0

  * Sources are from
    http://http.debian.net/debian/pool/main/p/python-django-overextends/python-django-overextends_0.4.0-1.dsc
  * Update runtime requirements according to global requirements of Mitaka
  * Add patch Temporary-remove-sphinx-me.patch

Change-Id: Id16679bb16bedfb6e1f491f231d16ca4811f623d
Partial-Bug: #1545692

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/trusty/django-classy-tags (master)

Reviewed: https://review.fuel-infra.org/18193
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: 22167a7c2c561315be2d739382266cb5f765675c
Author: Daniil Trishkin <email address hidden>
Date: Thu Mar 17 14:28:23 2016

Add django-classy-tags 0.7.2

  * Sources are from
    http://http.debian.net/debian/pool/main/d/django-classy-tags/django-classy-tags_0.7.2-1.dsc
  * Update runtime requirements according to global requirements of Mitaka

Partial-Bug: #1545692

Change-Id: Idee896006bcfa94f49cfe62a4f221f89ab6f8b14

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to packages/trusty/django-sekizai (master)

Reviewed: https://review.fuel-infra.org/18108
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: 85163fd7d1b4948c558475111648f72799e97efc
Author: Daniil Trishkin <email address hidden>
Date: Tue Mar 15 17:10:21 2016

Add django-sekizai 0.9.0

  * Sources are from
    http://http.debian.net/debian/pool/main/d/django-sekizai/django-sekizai_0.9.0-2.dsc
  * Update runtime dependencies according to global requirements of Mitaka

Change-Id: Idecacf8602d3472a32761187a7ae0da65169789b
Partial-Bug: #1545692

Dmitry (dtsapikov)
tags: added: on-verification
Dmitry (dtsapikov)
tags: removed: on-verification
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix merged to packages/trusty/python-django-compressor (master)

Reviewed: https://review.fuel-infra.org/18032
Submitter: Pkgs Jenkins <email address hidden>
Branch: master

Commit: 9714dfd8623e823a007831d64bf53e07ae4a936f
Author: Daniil Trishkin <email address hidden>
Date: Mon Mar 14 13:16:42 2016

Update to 2.0

  * Update runtime requirements according to global requirements of Mitaka
  * Sources are from
    http://http.debian.net/debian/pool/main/p/python-django-compressor/python-django-compressor_2.0-1.dsc

Change-Id: I6f97a83d967058275575160afaa60244d35f5d62
Related-Bug: #1545692

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix proposed to packages/trusty/python-django-compressor (9.0)

Related fix proposed to branch: 9.0
Change author: Daniil Trishkin <email address hidden>
Review: https://review.fuel-infra.org/18734

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix merged to packages/trusty/python-django-compressor (9.0)

Reviewed: https://review.fuel-infra.org/18734
Submitter: Pkgs Jenkins <email address hidden>
Branch: 9.0

Commit: 632673bcb5c7565a3597bb7686337f935ca83e1d
Author: Daniil Trishkin <email address hidden>
Date: Thu Mar 24 17:51:42 2016

Update to 2.0

  * Update runtime requirements according to global requirements of Mitaka
  * Sources are from
    http://http.debian.net/debian/pool/main/p/python-django-compressor/python-django-compressor_2.0-1.dsc

Change-Id: I6f97a83d967058275575160afaa60244d35f5d62
Related-Bug: #1545692
(cherry picked from commit 9714dfd8623e823a007831d64bf53e07ae4a936f)

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to mos-infra/mos-requirements (master)

Reviewed: https://review.fuel-infra.org/17089
Submitter: Igor Yozhikov <email address hidden>
Branch: master

Commit: 686d7022a49c4dcda814f3295656e668825d60ad
Author: Rodion Tikunov <email address hidden>
Date: Tue Feb 16 13:49:01 2016

Cap django-compressor for tests in 7.0

It will the newer 2.0 version failing with Django 1.7 we still
use in 7.0 (since version 2.0 removed Django 1.7 support).

Change-Id: Ib89a0e57296642705bf8ba9c46cb74d26b46bbb8
Partial-Bug: #1545692

Revision history for this message
Sergei Chipiga (schipiga) wrote :

checked with mos9.0#253.

At controller django-compressor v2.0-1~u14.04+mos1 is installed.

Fixed.

Revision history for this message
Rodion Tikunov (rtikunov) wrote :

Wont't fix for 8.0 because tests are well passed for this branch and updating django from 1.7 to 1.8 can be very dangerous.

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on packages/trusty/pep8 (master)

Change abandoned by Daniil Trishkin <email address hidden> on branch: master
Review: https://review.fuel-infra.org/18123

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Change abandoned on mos-infra/mos-requirements (master)

Change abandoned by Timur Sufiev <email address hidden> on branch: master
Review: https://review.fuel-infra.org/17077

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.