networking-midonet

clean up ml2 sg_callback

Bug #1549591 reported by YAMAMOTO Takashi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-midonet
Fix Released
Low
YAMAMOTO Takashi
networking-midonet 5.0.0

Bug Description

clean up the following REVISIT.

        # REVISIT(Ryu): Keep an extra set of strong references to the callback
        # methods so that they are not prematurely garbage collected.
        # This hack is required in the Liberty branch (not stable/kilo) because
        # currently the Liberty mechanism driver is expected to work with Kilo
        # ML2 plugin for MidoNet, and in Kilo ML2, there is a bug in which
        # these methods were referenced as weakrefs where a garbage collection
        # could remove these callbacks if they were part of an object.

YAMAMOTO Takashi (yamamoto)
Changed in networking-midonet:
importance: Undecided → Low
Marcellin Fom Tchassem (mf6510)
Changed in networking-midonet:
assignee: nobody → Marcellin Fom Tchassem (mf6510)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-midonet (master)

Fix proposed to branch: master
Review: https://review.openstack.org/290781

Changed in networking-midonet:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on networking-midonet (master)

Change abandoned by Marcellin Fom Tchassem (<email address hidden>) on branch: master
Review: https://review.openstack.org/290781

Marcellin Fom Tchassem (mf6510)
Changed in networking-midonet:
assignee: Marcellin Fom Tchassem (mf6510) → nobody
YAMAMOTO Takashi (yamamoto)
Changed in networking-midonet:
status: In Progress → New
YAMAMOTO Takashi (yamamoto)
tags: added: newton-backport-potential ocata-backport-potential
Changed in networking-midonet:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
milestone: none → 5.0.0
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-midonet (master)

Fix proposed to branch: master
Review: https://review.openstack.org/434634

Revision history for this message
YAMAMOTO Takashi (yamamoto) wrote :

https://review.openstack.org/434634

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-midonet (master)

Reviewed: https://review.openstack.org/434634
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=895bdeb97b86d3e5a99ac787fcfb96a0cb47f447
Submitter: Jenkins
Branch: master

commit 895bdeb97b86d3e5a99ac787fcfb96a0cb47f447
Author: YAMAMOTO Takashi <email address hidden>
Date: Thu Feb 16 13:07:35 2017 +0900

    sg_callback: Remove a hack for kilo

    The use of weakref has been removed from
    the callback registry long ago. [1]

    [1] Idcd0286fc4235af82901c8a17ea45bc758b62b37

    Closes-Bug: #1549591
    Change-Id: Ib0fa10bcd35ac419bbf2237d63974f965be91963

Changed in networking-midonet:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-midonet 5.0.0.0b2

This issue was fixed in the openstack/networking-midonet 5.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.