Juniper Openstack

Restoring of conf files needs to change from wholesale to specific

Bug #1551405 reported by Raj Reddy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.0
Fix Committed
High
Ignatious Johnson Christopher
Juniper Openstack r3.0.1.0
Trunk
Fix Committed
High
Ignatious Johnson Christopher
Juniper Openstack r3.1.0.0-fcs

Bug Description

As seen below, we copy files with '*' -- causes issues.. basically if we rerun this, it will overwrite files updated in the later steps..
we should copy specific files required for that package(s)..

2016-02-29 10:27:30:982897: [root@10.87.129.173] out: 0 upgraded, 0 newly installed, 0 to remove and 130 not upgraded.
2016-02-29 10:27:30:990515: [root@10.87.129.173] out: Restoring /var/tmp/contrail-3.0.0.0-2722-upgradesave/etc/contrail to: /etc/contrail
2016-02-29 10:27:30:990737: [root@10.87.129.173] out: [localhost] local: cp -rfp /var/tmp/contrail-3.0.0.0-2722-upgradesave/etc/contrail/* /etc/contrail
2016-02-29 10:27:30:991027: [root@10.87.129.173] out: Restoring /var/tmp/contrail-3.0.0.0-2722-upgradesave/etc/keystone to: /etc/keystone
2016-02-29 10:27:31:007194: [root@10.87.129.173] out: [localhost] local: cp -rfp /var/tmp/contrail-3.0.0.0-2722-upgradesave/etc/keystone/* /etc/keystone
2016-02-29 10:27:31:007403: [root@10.87.129.173] out: Restoring /var/tmp/contrail-3.0.0.0-2722-upgradesave/etc/glance to: /etc/glance
2016-02-29 10:27:31:007639: [root@10.87.129.173] out: [localhost] local: cp -rfp /var/tmp/contrail-3.0.0.0-2722-upgradesave/etc/glance/* /etc/glance
2016-02-29 10:27:31:007875: [root@10.87.129.173] out: Restoring /var/tmp/contrail-3.0.0.0-2722-upgradesave/etc/nova to: /etc/nova
2016-02-29 10:27:31:009863: [root@10.87.129.173] out: [localhost] local: cp -rfp /var/tmp/contrail-3.0.0.0-2722-upgradesave/etc/nova/* /etc/nova
2016-02-29 10:27:31:010018: [root@10.87.129.173] out: Restoring /var/tmp/contrail-3.0.0.0-2722-upgradesave/etc/cinder to: /etc/cinder
2016-02-29 10:27:31:013632: [root@10.87.129.173] out: [localhost] local: cp -rfp /var/tmp/contrail-3.0.0.0-2722-upgradesave/etc/cinder/* /etc/cinder
2016-02-29 10:27:31:013754: [root@10.87.129.173] out: [localhost] local: service supervisor-openstack restart
2016-02-29 10:27:31:021259: [root@10.87.129.173] out: stop: Unknown instance:

Raj Reddy (rajreddy)
Changed in juniperopenstack:
milestone: r3.0.1.0 → future
importance: Undecided → High
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/18044
Submitter: Ignatious Johnson Christopher (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/18045
Submitter: Ignatious Johnson Christopher (<email address hidden>)

Raj Reddy (rajreddy)
tags: added: releasenote
Ashish Ranjan (aranjan-n)
information type: Proprietary → Public
Revision history for this message
Raj Reddy (rajreddy) wrote :

Release Note Text:

The Upgrade script is not re-entrant. If it fails the first time, then when it runs second time, the updated conf files may get overwritten and services may show as down in contrail-status and may not work as expected.

Workaround is to update the upgrade script when a failure is seen, before it is run the second time.

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/18045
Committed: http://github.org/Juniper/contrail-provisioning/commit/b6cceda739538020da53bc945d72fd6d70b99584
Submitter: Zuul
Branch: R3.0

commit b6cceda739538020da53bc945d72fd6d70b99584
Author: Ignatious Johnson Christopher <email address hidden>
Date: Mon Feb 29 14:35:49 2016 -0800

Never restore /etc/contrail fully, Because all contrail
services share same config dir, During upgrade rerun
restoring whole /etc/contrail will replace config files
with older version. Also in openstack node there is no need
for /etc/contrail restore, /etc/contrail/ha restore is suffecient
in case of HA setup.

Change-Id: I4c70f932a6be496973bc55078a72908547d9882e
Closes-Bug: 1551405

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/18044
Committed: http://github.org/Juniper/contrail-provisioning/commit/cf7b44310800ebe78bb18e4377d102c698467b60
Submitter: Zuul
Branch: master

commit cf7b44310800ebe78bb18e4377d102c698467b60
Author: Ignatious Johnson Christopher <email address hidden>
Date: Mon Feb 29 14:35:49 2016 -0800

Never restore /etc/contrail fully, Because all contrail
services share same config dir, During upgrade rerun
restoring whole /etc/contrail will replace config files
with older version. Also in openstack node there is no need
for /etc/contrail restore, /etc/contrail/ha restore is suffecient
in case of HA setup.

Change-Id: I4c70f932a6be496973bc55078a72908547d9882e
Closes-Bug: 1551405

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.