Make the song-footer text "Written by" optional
Bug #1557579 reported by
Tomas Groth
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Committed
|
Wishlist
|
Azaziah | ||
Bug Description
In 2.2 "Written by" was included in the song footer text to make it more clear who was the author of the song.
Multiple users has asked if it can be made optional.
Related branches
lp://qastaging/~suutari-olli/openlp/add-bible-license-field
- Raoul Snyman: Approve
- Tim Bentley: Approve
-
Diff: 400 lines (+125/-23)9 files modifiedopenlp/core/common/uistrings.py (+10/-7)
openlp/plugins/bibles/forms/bibleimportform.py (+17/-2)
openlp/plugins/bibles/forms/editbibledialog.py (+7/-0)
openlp/plugins/bibles/forms/editbibleform.py (+23/-4)
openlp/plugins/bibles/lib/manager.py (+5/-5)
openlp/plugins/songs/lib/mediaitem.py (+7/-2)
openlp/plugins/songs/lib/songstab.py (+13/-1)
openlp/plugins/songs/songsplugin.py (+1/-0)
tests/functional/openlp_plugins/songs/test_mediaitem.py (+42/-2)
Revision history for this message
| Samuel Mehrbrodt (sam92) wrote | #1 |
Revision history for this message
| Tomas Groth (tomasgroth) wrote | #2 |
Revision history for this message
| Azaziah (suutari-olli) wrote | #3 |
| Changed in openlp: | |
| assignee: | nobody → Azaziah (suutari-olli) |
| Changed in openlp: | |
| status: | Confirmed → In Progress |
| Changed in openlp: | |
| milestone: | none → 2.5.1 |
| Changed in openlp: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
"Written by" is used when no author type has been given - should we rather just prefix it with "Author" in that case?