OpenStack Dashboard (Horizon)

Magic-Search shouldn't exist inside of table structure

Bug #1558772 reported by Matt Borland
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum UI
Fix Released
High
Shu Muto
Magnum UI newton-1 "n1"
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Matt Borland
OpenStack Dashboard (Horizon) newton-1 "n1"
OpenStack Searchlight
Fix Released
High
Matt Borland
OpenStack Searchlight newton-1 "n1"

Bug Description

Currently, the way the Angular Magic-Search directive works, it requires being placed in the context of a smart-table. This is not ideal and causes trouble with formatting.

A good solution would allow the search bar directive to be placed outside of the table structure in the markup.

Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
importance: Undecided → Wishlist
milestone: none → ongoing
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/297291

Changed in horizon:
assignee: nobody → Matt Borland (palecrow)
status: Confirmed → In Progress
Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
milestone: ongoing → next
Revision history for this message
Travis Tripp (travis-tripp) wrote :

Once this gets into horizon, the change will affect searchlight and searchlight-ui must be updated.

Changed in searchlight:
importance: Undecided → Critical
status: New → In Progress
Changed in horizon:
milestone: next → newton-1
Changed in searchlight:
milestone: none → newton-1
importance: Critical → High
assignee: nobody → Matt Borland (palecrow)
OpenStack Infra (hudson-openstack)
Changed in horizon:
assignee: Matt Borland (palecrow) → Timur Sufiev (tsufiev-x)
Timur Sufiev (tsufiev-x)
Changed in horizon:
assignee: Timur Sufiev (tsufiev-x) → Matt Borland (palecrow)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/297291
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e86b1e4c064c88920c25be31238113129ab061ed
Submitter: Jenkins
Branch: master

commit e86b1e4c064c88920c25be31238113129ab061ed
Author: Matt Borland <email address hidden>
Date: Thu Mar 24 11:54:42 2016 -0600

    Move magic-search bar out of the smart-table structure

    This patch allows the magic-search bar to be moved out of the
    smart-table table structure. This was causing trouble for styling but
    also didn't allow for much flexibility in layout.

    Closes-Bug: 1558772

    Change-Id: I461b233e56ddf404d75c094c54473e43ee50e7c8

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to searchlight-ui (master)

Reviewed: https://review.openstack.org/306540
Committed: https://git.openstack.org/cgit/openstack/searchlight-ui/commit/?id=3a8a437585fff45d1d0f879a22a9dc520015e421
Submitter: Jenkins
Branch: master

commit 3a8a437585fff45d1d0f879a22a9dc520015e421
Author: Matt Borland <email address hidden>
Date: Fri Apr 15 10:52:00 2016 -0600

    Move search bar out of table

    Based on upstream's move of the search bar out of the table, this patch
    follows suit.

    Change-Id: Ia1e21c661b074cf0cc12564f8fc59ec1b0f8404f
    Depends-On: I461b233e56ddf404d75c094c54473e43ee50e7c8
    Partial-Bug: 1558772

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/309212
Committed: https://git.openstack.org/cgit/openstack/searchlight-ui/commit/?id=0c268301e910ae6cfc279d0ca104e93390df49ba
Submitter: Jenkins
Branch: master

commit 0c268301e910ae6cfc279d0ca104e93390df49ba
Author: Travis Tripp <email address hidden>
Date: Fri Apr 22 08:56:06 2016 -0600

    Add version compatibility matrix to Readme

    Based on upstream's move of the search bar out of the table,
    there is now a version dependency with horizon upstream.
    This adds a readme to the repo for quick reference.

    Change-Id: I46b36e4dfadc262fbd129ed287bde6f8a84f1f77
    Partial-Bug: 1558772

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/309538
Committed: https://git.openstack.org/cgit/openstack/searchlight-ui/commit/?id=10f5c4113ce47ee56b26c8070bc6ab66d23c1908
Submitter: Jenkins
Branch: master

commit 10f5c4113ce47ee56b26c8070bc6ab66d23c1908
Author: Travis Tripp <email address hidden>
Date: Fri Apr 22 11:54:45 2016 -0600

    Apply formatting to search table html

    This applies formatting to the HTML after the below fix was done.

    https://review.openstack.org/#/c/306540/

    Change-Id: I034d2f226b63dcc1a01ec295446dafb7cc4437f0
    Partial-Bug: 1558772

Travis Tripp (travis-tripp)
Changed in searchlight:
status: In Progress → Fix Committed
Shu Muto (shu-mutou)
Changed in magnum-ui:
assignee: nobody → Shu Muto (shu-mutou)
importance: Undecided → High
status: New → In Progress
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/317829

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum-ui (master)

Reviewed: https://review.openstack.org/317829
Committed: https://git.openstack.org/cgit/openstack/magnum-ui/commit/?id=3bd93a817a5f6d8c3afe70b13d97e46b927b78bf
Submitter: Jenkins
Branch: master

commit 3bd93a817a5f6d8c3afe70b13d97e46b927b78bf
Author: shu-mutou <email address hidden>
Date: Wed May 18 13:36:30 2016 +0900

    Move magic-search bar out of the table structure

    This patch moves the magic-search bar to out of the table structure.
    Also this patch allows much flexibility in layout.

    Change-Id: I0312d79143515b0a82a2b17776fbb502a36b6b03
    Closes-Bug: #1558772

Changed in magnum-ui:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/magnum-ui 2.0.0

This issue was fixed in the openstack/magnum-ui 2.0.0 release.

Travis Tripp (travis-tripp)
Changed in searchlight:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.