OpenStack Dashboard (Horizon)

Unlocalized text shown in Create Container window

Bug #1561761 reported by Yuko Katabami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Richard Jones
OpenStack Dashboard (Horizon) newton-1 "n1"

Bug Description

Project > Object Store > Containers > Create Container

The following text appears unlocalized.
It exists in pot files, and already translated in zanata, but not shown localized in Horizon.

File: openstack_dashboard/locale/django and openstack_dashboard/locale/djangojs

Source text: A container is a storage compartment for your data and provides a way for you to organize your data. You can think of a container as a folder in Windows ® or a directory in UNIX ®. The primary difference between a container and these other file system concepts is that containers cannot be nested. You can, however, create an unlimited number of containers within your account. Data must be stored in a container so you must have at least one container defined in your account prior to uploading data.

Tomonobu Niwa (to-niwa)
Changed in horizon:
assignee: nobody → Tomonobu Niwa (to-niwa)
Rob Cresswell (robcresswell-deactivatedaccount)
tags: added: i18n
Changed in horizon:
status: New → Confirmed
importance: Undecided → High
milestone: none → newton-1
tags: added: mitaka-backport-potential
Revision history for this message
Richard Jones (r1chardj0n3s) wrote :

The HTML entity is being stripped out :-(

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/302526

Changed in horizon:
assignee: Tomonobu Niwa (to-niwa) → Richard Jones (r1chardj0n3s)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/302526
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fdf0bf6f186f056fea6ed5761616c40463a2e269
Submitter: Jenkins
Branch: master

commit fdf0bf6f186f056fea6ed5761616c40463a2e269
Author: Richard Jones <email address hidden>
Date: Thu Apr 7 14:28:05 2016 +1000

    Fix babel msgids to include tag attributes and entities

    The messages for translation were omitting the attributes in
    tags and HTML entities embedded in the translation strings,
    thus they no longer matched the original HTML.

    Additionally, HTML entities are mostly (but not always) decoded
    by the browser before angular-gettext sees them, so we have to
    emulate this behaviour in our babel extractor so the message
    ids match.

    Change-Id: Ie6ae0776a2c0d7db589b34a9e7676508178a473d
    Closes-Bug: 1561550
    Closes-Bug: 1561738
    Closes-Bug: 1561761

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/316767

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/mitaka)

Reviewed: https://review.openstack.org/316767
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=dfeacc294fec956fd98892d4ad6534a9427bc3a1
Submitter: Jenkins
Branch: stable/mitaka

commit dfeacc294fec956fd98892d4ad6534a9427bc3a1
Author: Richard Jones <email address hidden>
Date: Thu Apr 7 14:28:05 2016 +1000

    Fix babel msgids to include tag attributes and entities

    The messages for translation were omitting the attributes in
    tags and HTML entities embedded in the translation strings,
    thus they no longer matched the original HTML.

    Additionally, HTML entities are mostly (but not always) decoded
    by the browser before angular-gettext sees them, so we have to
    emulate this behaviour in our babel extractor so the message
    ids match.

    Change-Id: Ie6ae0776a2c0d7db589b34a9e7676508178a473d
    Closes-Bug: 1561550
    Closes-Bug: 1561738
    Closes-Bug: 1561761
    (cherry picked from commit fdf0bf6f186f056fea6ed5761616c40463a2e269)

tags: added: in-stable-mitaka
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 9.0.1

This issue was fixed in the openstack/horizon 9.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.