Tutorials related to class Meta should use new style

Bug #1564193 reported by guoshan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
guoshan

Bug Description

The tutorials still use the old style class declaration.

class MyTable(DataTable):
    name = Column('name')
    email = Column('email')

    class Meta:
        name = "my_table"
        table_actions = (MyAction, MyOtherAction)
        row_actions - (MyAction)

It should use new style (inherit from 'object').

guoshan (guoshan)
Changed in horizon:
assignee: nobody → guoshan (guoshan)
Changed in horizon:
importance: Undecided → Low
milestone: none → ongoing
status: New → Confirmed
Changed in horizon:
status: Confirmed → In Progress
Changed in horizon:
milestone: ongoing → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/299818
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=a7da1dae4d005d104b88d471eb30c9da79c870ad
Submitter: Jenkins
Branch: master

commit a7da1dae4d005d104b88d471eb30c9da79c870ad
Author: guoshan <email address hidden>
Date: Thu Mar 31 17:12:12 2016 +0800

    Tutorials related to class Meta should use new style

    The tutorials still use the old style class declaration.
    class MyTable(DataTable):
        name = Column('name')
        email = Column('email')

        class Meta:
            name = "my_table"
            table_actions = (MyAction, MyOtherAction)
            row_actions - (MyAction)
    It should use new style (inherit from 'object').

    Change-Id: Icad23f6359f5f4866c5819f351f5c5cf1c3521fd
    closes-bug:#1564193

Changed in horizon:
status: In Progress → Fix Released
Changed in horizon:
milestone: next → newton-1
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.