OpenStack Dashboard (Horizon)

Integration tests don't actually wait until table row is deleted

Bug #1564405 reported by Timur Sufiev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Timur Sufiev
OpenStack Dashboard (Horizon) newton-1 "n1"

Bug Description

Usually it goes unnoticed because objects are deleted at the end of a test (cleanUp phase) - and the deletion manages to finish before the next test is launched, but when a dependent entities A<-B are deleted in order, sometimes not waiting for B to delete leads to failure while deleting A (a good example here is Volume <- Volumes Snapshot).

This was caused by too broad exception clause here https://github.com/openstack/horizon/blob/2015.1.0rc2/openstack_dashboard/test/integration_tests/basewebobject.py#L42 (in reality exception was raised due to absence of .is_displayed() method in RowRegion, we had to invoke element.src_elem.is_displayed() in that case).

Timur Sufiev (tsufiev-x)
Changed in horizon:
importance: Undecided → High
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/299934

Changed in horizon:
assignee: nobody → Timur Sufiev (tsufiev-x)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/299934
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e63b5d86acee7e587829e4a4f581ed8d5a56051f
Submitter: Jenkins
Branch: master

commit e63b5d86acee7e587829e4a4f581ed8d5a56051f
Author: Timur Sufiev <email address hidden>
Date: Thu Mar 31 16:35:20 2016 +0300

    Make i9n tests correctly recognize the deletion of a last row in a table

    First, .is_displayed() method inside RowRegion needs to be invoked
    correctly. Second, we need to distinguish an .empty placeholder row
    from the last deleted row which contents are replaced with .empty row
    contents from inside. Otherwise these 2 rows are considered the same
    by tests. This is done by checking first for empty_table_selector.

    Change-Id: I1abeb9f5ffc94213011e24eda99bb8a1ca8bfaeb
    Closes-Bug: #1564405

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.