Update stack doesn't pause with pre-update hook set

Bug #1564613 reported by Ying Zuo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Ying Zuo

Bug Description

Steps to reproduce:
1. Go to Project -> Orchestration panel
2. Click launch a stack
3. Enter the following in template source
heat_template_version: 2015-04-30
resources:
  test_resource_pause:
     type: OS::Heat::TestResource
     properties:
       action_wait_secs: {"delete": 5, "create": 5, "update": 5}
       client_name: openstack
4. Enter the following in environment source
resource_registry:
  resources:
     test_resource_pause:
        type: OS::Heat::TestResource
        hooks: pre-update
5. Enter other stack information
6. After the stack is created, click on update stack template
7. Enter the template and environment source as in step 3 and 4 and click update stack
8. The stack was updated successfully right away

Expect the update action will stay in progress until the pre-update hook is cleared.

This issue appears to be a heat defect but it's actually caused by horizon not passing the environment data to the heat api.

Ying Zuo (yingzuo)
Changed in horizon:
assignee: nobody → Ying Zuo (yingzuo)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/300214

Changed in horizon:
status: New → In Progress
Changed in horizon:
importance: Undecided → High
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/300214
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f65ff0fe912ba04f052aeff70eb26a6bdede5838
Submitter: Jenkins
Branch: master

commit f65ff0fe912ba04f052aeff70eb26a6bdede5838
Author: Ying Zuo <email address hidden>
Date: Thu Mar 31 13:58:56 2016 -0700

    Pass environment data to update stack action

    Change-Id: I7df7f1664ab067b287cffab4187c16a10ad4abba
    Closes-bug: #1564613

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/307885

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/mitaka)

Reviewed: https://review.openstack.org/307885
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=722a7b3b335eeadf88a77e3df5c8f176a8e2b02b
Submitter: Jenkins
Branch: stable/mitaka

commit 722a7b3b335eeadf88a77e3df5c8f176a8e2b02b
Author: Ying Zuo <email address hidden>
Date: Thu Mar 31 13:58:56 2016 -0700

    Pass environment data to update stack action

    Change-Id: I7df7f1664ab067b287cffab4187c16a10ad4abba
    Closes-bug: #1564613
    (cherry picked from commit f65ff0fe912ba04f052aeff70eb26a6bdede5838)

tags: added: in-stable-mitaka
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 9.0.1

This issue was fixed in the openstack/horizon 9.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.