Incorrect diff bytes in flow-samples exported from agent

Bug #1572473 reported by Ashok Singh
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.20
Fix Committed
Medium
Ashok Singh
R2.22.x
Fix Committed
Medium
Ashok Singh
R3.0
Fix Committed
Medium
Ashok Singh
Trunk
Fix Committed
Medium
Ashok Singh

Bug Description

When a flow export message is dropped, the diff stats considered for exporting that flow next time, should be diff since previous send and not since previous attempt to send. Currently it is possible that a flow export message is dropped from agent because of sampling and next time the flow is exported, it is exported with incorrect diff stats.

Also define separate counters for flow-export-message drops to indicate flow export message drops reason
 -drops due to disable of flow-export
 -drops due to subjecting flow-exports to flow-sampling.

Tags: vrouter
Changed in juniperopenstack:
importance: Undecided → Medium
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/19489
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/19520
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/19489
Committed: http://github.org/Juniper/contrail-controller/commit/245a204b9f9a0739acc9ba568792c8da3670c359
Submitter: Zuul
Branch: master

commit 245a204b9f9a0739acc9ba568792c8da3670c359
Author: ashoksingh <email address hidden>
Date: Wed Apr 20 14:52:29 2016 +0530

Use adaptive diff stats while exporting flows

Problem
———----
When a flow export message is dropped, the diff bytes/packets
computed for that flow is not retained. Next time when is flow
is being exported the new diff bytes/packets computed will be
since the last time it was attempted to be sent. This will
result in incorrect diff bytes/packets being exported for flows

Fix
--—
When a flow sample is dropped retain the diff bytes/packets for
this flow. Next time when this flow is being exported the diff
bytes/packets computed will include the previous diff bytes/packets
retained for that flow.

Also replace the count "flow-export-msg-drops" with the following
--drops due to disable of flow-export
--drops because of subjecting flows to flow-sampling

Change-Id: Ie808bd3dcdb584ddbc1a7e2810183fbf399c98c9
Closes-Bug: #1572473

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22.x

Review in progress for https://review.opencontrail.org/19561
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/19562
Submitter: Ashok Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/19520
Committed: http://github.org/Juniper/contrail-controller/commit/5f3024d81cf6d902f5af4eba4b719d4565334411
Submitter: Zuul
Branch: R3.0

commit 5f3024d81cf6d902f5af4eba4b719d4565334411
Author: ashoksingh <email address hidden>
Date: Thu Apr 21 12:23:35 2016 +0530

Use adaptive diff stats while exporting flows

Problem
———----
When a flow export message is dropped, the diff bytes/packets
computed for that flow is not retained. Next time when is flow
is being exported the new diff bytes/packets computed will be
since the last time it was attempted to be sent. This will
result in incorrect diff bytes/packets being exported for flows

Fix
--—
When a flow sample is dropped retain the diff bytes/packets for
this flow. Next time when this flow is being exported the diff
bytes/packets computed will include the previous diff bytes/packets
retained for that flow.

Also replace the count "flow-export-msg-drops" with the following
--drops due to disable of flow-export
--drops because of subjecting flows to flow-sampling

Change-Id: I191b22c0a1b072338b8ca3e7708e5bc9e8faf031
Closes-Bug: #1572473

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/19561
Committed: http://github.org/Juniper/contrail-controller/commit/339a217b0c3223705844f518983d14d012724e9d
Submitter: Zuul
Branch: R2.22.x

commit 339a217b0c3223705844f518983d14d012724e9d
Author: ashoksingh <email address hidden>
Date: Fri Apr 22 15:10:12 2016 +0530

Use adaptive diff stats while exporting flows

Problem
———----
When a flow export message is dropped, the diff bytes/packets
computed for that flow is not retained. Next time when is flow
is being exported the new diff bytes/packets computed will be
since the last time it was attempted to be sent. This will
result in incorrect diff bytes/packets being exported for flows

Fix
--—
When a flow sample is dropped retain the diff bytes/packets for
this flow. Next time when this flow is being exported the diff
bytes/packets computed will include the previous diff bytes/packets
retained for that flow.

Also replace the count "flow-export-msg-drops" with the following
--drops due to disable of flow-export
--drops because of subjecting flows to flow-sampling

Change-Id: I2fd6b45cc7d5ef472594aac3494509f9bbf14396
Closes-Bug: #1572473

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/19562
Committed: http://github.org/Juniper/contrail-controller/commit/78eebfb6c885b4f6f5f0135c9302146b1b9dfc5a
Submitter: Zuul
Branch: R2.20

commit 78eebfb6c885b4f6f5f0135c9302146b1b9dfc5a
Author: ashoksingh <email address hidden>
Date: Fri Apr 22 15:10:12 2016 +0530

Use adaptive diff stats while exporting flows

Problem
———----
When a flow export message is dropped, the diff bytes/packets
computed for that flow is not retained. Next time when is flow
is being exported the new diff bytes/packets computed will be
since the last time it was attempted to be sent. This will
result in incorrect diff bytes/packets being exported for flows

Fix
--—
When a flow sample is dropped retain the diff bytes/packets for
this flow. Next time when this flow is being exported the diff
bytes/packets computed will include the previous diff bytes/packets
retained for that flow.

Also replace the count "flow-export-msg-drops" with the following
--drops due to disable of flow-export
--drops because of subjecting flows to flow-sampling

Closes-Bug: #1572473
(cherry picked from commit 339a217b0c3223705844f518983d14d012724e9d)

Change-Id: I5990fd688f83004489aca008d41d802d03b4fd29

information type: Proprietary → Public
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.