networking-bgpvpn

new probe port not connected to bgpvpn

Bug #1575662 reported by Przemyslaw JASEK
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-bgpvpn
Fix Released
Medium
Thomas Morin
networking-bgpvpn 4.0.0 "mitaka"

Bug Description

Probe port: qprobe-75f701cb-2082-4e20-b183-737a6b79074d

q-svc log:

2016-04-26 16:57:46.013 INFO networking_bgpvpn.neutron.services.service_drivers.bagpipe.bagpipe [req-f387bc24-79e5-4b57-adbf-014077b12479 None None] notify_port_updated on port 75f701cb-2082-4e20-b183-737a6b79074d
2016-04-26 16:57:46.234 INFO networking_bgpvpn.neutron.services.service_drivers.bagpipe.bagpipe [req-f387bc24-79e5-4b57-adbf-014077b12479 None None] Port 75f701cb-2082-4e20-b183-737a6b79074d owner is network:*, we'll do nothing

This bug concerns "_ignore_port" function of bagpipe.py (https://goo.gl/U1ndGr)
L381: const.DEVICE_OWNER_NETWORK_PREFIX = "network:" and for probe port: port['device_owner'] = "network:probe"

This causes to return 'True' and finally exit from 'notify_port_updated' too soon. I guess this originaly prevents dhcp port from connecting to BGPVPN (for DHCP port port['device_owner'] = "network:dhcp") and probe is taken into account as well.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-bgpvpn (master)

Fix proposed to branch: master
Review: https://review.openstack.org/310467

Changed in bgpvpn:
assignee: nobody → Thomas Morin (tmmorin-orange)
status: New → In Progress
Thomas Morin (tmmorin-orange)
Changed in bgpvpn:
importance: Undecided → Medium
milestone: none → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-bgpvpn (master)

Reviewed: https://review.openstack.org/310467
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=d3135c36a9de167ce81c5f2780c542998ae00209
Submitter: Jenkins
Branch: master

commit d3135c36a9de167ce81c5f2780c542998ae00209
Author: Thomas Morin <email address hidden>
Date: Wed Apr 27 07:33:54 2016 -0500

    bagpipe: do not ignore probe ports

    4488cf53ed9c0f0c5d520158e09a4b6fb040ac19 introduced a check
    in bagpipe driver to ignore network:* ports, which is the desired
    behavior, except for probe ports, which we don't want to ignore
    to allow testing with probe ports.

    This change relaxes the check to not ignore probe ports.

    Przemyslaw Jasek reported this bug and suggested the fix.

    Change-Id: Icad59a0d7deda38de3216a3be9ca7e75f6beff55
    Closes-Bug: 1575662

Changed in bgpvpn:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-bgpvpn (master)

Fix proposed to branch: master
Review: https://review.openstack.org/311729

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-bgpvpn (master)

Reviewed: https://review.openstack.org/311729
Committed: https://git.openstack.org/cgit/openstack/networking-bgpvpn/commit/?id=caccb967a321b9097795bd05c466b57374f2bb3d
Submitter: Jenkins
Branch: master

commit caccb967a321b9097795bd05c466b57374f2bb3d
Author: Thomas Morin <email address hidden>
Date: Mon May 2 14:28:43 2016 +0200

    bagpipe: ignore all probe ports

    Icad59a0d7deda38de3216a3be9ca7e75f6beff55 was introduced to
    ignore probe ports but only ignored "compute:probe" but not
    "network:probe" ports.

    With this change, bagpipe driver ignores all probe ports.

    Change-Id: Icdb6355d107c969638521b6ddefd29dd96913016
    Closes-Bug: 1575662

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.