[Contrail 4.0] Plugin tests did not pass shellcheck
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Fuel Contrail plugin |
Fix Released
|
Medium
|
Yevgeniy |
Bug Description
Scenario:
1. Install shellcheck
2.Run shellcheck for plugin_
Actual result:
yshapovalov@
In plugin_
if [ -z $NODE_VOLUME_SIZE ]; then export NODE_VOLUME_
^-- SC2086: Double quote to prevent globbing and word splitting.
In plugin_
if [ -z $OPENSTACK_RELEASE ]; then export OPENSTACK_
^-- SC2086: Double quote to prevent globbing and word splitting.
In plugin_
if [ -z $ENV_NAME ]; then export ENV_NAME=
^-- SC2086: Double quote to prevent globbing and word splitting.
In plugin_
if [ -z $ADMIN_NODE_MEMORY ]; then export ADMIN_NODE_
^-- SC2086: Double quote to prevent globbing and word splitting.
In plugin_
if [ -z $ADMIN_NODE_CPU ]; then export ADMIN_NODE_CPU=4; fi
^-- SC2086: Double quote to prevent globbing and word splitting.
In plugin_
if [ -z $SLAVE_NODE_MEMORY ]; then export SLAVE_NODE_
^-- SC2086: Double quote to prevent globbing and word splitting.
In plugin_
if [ -z $SLAVE_NODE_CPU ]; then export SLAVE_NODE_CPU=4; fi
^-- SC2086: Double quote to prevent globbing and word splitting.
In plugin_
ISO="`ls ${WORKSPACE}
^-- SC2006: Use $(..) instead of deprecated `..`
^-- SC2012: Use find instead of ls to better handle non-alphanumeric filenames.
^-- SC2086: Double quote to prevent globbing and word splitting.
In plugin_
In plugin_
In plugin_
mkdir -p $LOGS_DIR
^-- SC2086: Double quote to prevent globbing and word splitting.
In plugin_
if [ $(dos.py list | grep "^${ENV_NAME}\$") ]; then
^-- SC2046: Quote this to prevent word splitting.
^-- SC2143: Instead of [ -n $(foo | grep bar) ], use foo | grep -q bar .
In plugin_
echo python plugin_
In plugin_
echo ${PYTHONPATH}
^-- SC2086: Double quote to prevent globbing and word splitting.
In plugin_
python plugin_
In plugin_
GetoptsVariables ${@}
Changed in fuel-plugin-contrail: | |
status: | New → In Progress |
Changed in fuel-plugin-contrail: | |
status: | In Progress → Fix Committed |
https:/ /review. openstack. org/#/c/ 312878/