OpenStack Dashboard (Horizon)

Limit summary view on project/overview page is broken when amount of charts is changed

Bug #1578978 reported by Valeriy Ponomaryov
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Ryan Peters
OpenStack Dashboard (Horizon) newton-1 "n1"

Bug Description

Commit [1] introduced bug of wrong compilation of html tags in [2] template.
It improperly handles chart elements when their amount does not satisfy criterion "(amount-1) % 2 = 0". "Bug" is in not closed "div" element that leads to improper interpretation of elements on page.
Also, this template always shows 6 elements on each row and one more on the new one. This template should not split charts by rows explicitly. It fits page nicely without it.

For the moment it looks as 2 rows aligned for left on wide screen.

[1] https://github.com/openstack/horizon/commit/3a2564e3
[2] https://github.com/openstack/horizon/blob/3a2564e3/horizon/templates/horizon/common/_limit_summary.html

Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :

It was introduced in Mitaka timeframe. So, it is potential backport.

Changed in horizon:
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/313296

Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :

To test it just change integer value on [1] and [2] lines in "..divisibleby:6" part. For example, to "divisibleby:5".

[1] https://github.com/openstack/horizon/blob/3a2564e3/horizon/templates/horizon/common/_limit_summary.html#L7
[2] https://github.com/openstack/horizon/blob/3a2564e3/horizon/templates/horizon/common/_limit_summary.html#L10

Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :

It also should be backported to Mitaka stable release as it is affected too.

Diana Whitten (hurgleburgler)
Changed in horizon:
milestone: none → newton-1
importance: Undecided → Low
OpenStack Infra (hudson-openstack)
Changed in horizon:
assignee: Valeriy Ponomaryov (vponomaryov) → Ryan Peters (rjpeter2)
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Valerie: you can tag bugs with mitaka-backport-potential if you believe they should be back ported.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/294289
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f8cb496735a5c8e38f1189be9fdfc284ff70c753
Submitter: Jenkins
Branch: master

commit f8cb496735a5c8e38f1189be9fdfc284ff70c753
Author: Ryan Peters <email address hidden>
Date: Thu Mar 17 16:14:44 2016 -0500

    Add semantic markup to Project Overview page

    Add a limit-summary class to the graphs on the overview page
    and fix the logic of making the rows.

    Change-Id: I396724ec5af874021fbfd673e7c49c5fec83245f
    Closes-Bug: #1578978
    Closes-Bug: #1579164

Changed in horizon:
status: In Progress → Fix Released
Valeriy Ponomaryov (vponomaryov)
tags: added: mitaka-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Valeriy Ponomaryov (<email address hidden>) on branch: master
Review: https://review.openstack.org/313296

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.