Charm attempts to add devices already in use

Bug #1582317 reported by Francis Ginther
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Swift Storage Charm
Fix Released
High
viswesuwara nathan
swift-storage (Juju Charms Collection)
Invalid
High
viswesuwara nathan

Bug Description

There are cases where in-use or duplicate block-devices are passed to swift-storage. The charm does not appear to determine if the devices are already in use before attempting to consume them.

In this case, duplicate block-devices were specified (http://paste.ubuntu.com/16463831/ see wwn-0x6000c29ffa0be386f737ee5c2ab91815). The charm then tried to add that device multiple times (after converting it to "/dev/sdb"): http://paste.ubuntu.com/16463865/

Attached is a tgz with the output of "juju get swift-storage" and /var/log/juju/unit-swift-storage-0.log.

Tags: landscape
Revision history for this message
Francis Ginther (fginther) wrote :
tags: added: landscape
tags: added: kanban-cross-team
tags: removed: kanban-cross-team
description: updated
Changed in swift-storage (Juju Charms Collection):
assignee: nobody → viswesuwara nathan (viswesn)
Changed in swift-storage (Juju Charms Collection):
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to charm-swift-storage (master)

Fix proposed to branch: master
Review: https://review.openstack.org/397291

Revision history for this message
viswesuwara nathan (viswesn) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-swift-storage (master)

Reviewed: https://review.openstack.org/397291
Committed: https://git.openstack.org/cgit/openstack/charm-swift-storage/commit/?id=b268ef82fa6d17d0abccb0d13f3eaa2b9d48a0df
Submitter: Jenkins
Branch: master

commit b268ef82fa6d17d0abccb0d13f3eaa2b9d48a0df
Author: vnathan <email address hidden>
Date: Mon Nov 14 22:09:58 2016 +0530

    Fixed handling duplicate block devices specified in config

    Change-Id: I5c96c49d47b762fecc16c8700ef6ed65bcd39bf5
    closes-bug: 1582317

Changed in swift-storage (Juju Charms Collection):
status: In Progress → Fix Committed
Liam Young (gnuoy)
Changed in swift-storage (Juju Charms Collection):
importance: Undecided → High
milestone: none → 17.01
James Page (james-page)
Changed in charm-swift-storage:
assignee: nobody → viswesuwara nathan (viswesn)
importance: Undecided → High
status: New → Fix Committed
Changed in swift-storage (Juju Charms Collection):
status: Fix Committed → Invalid
James Page (james-page)
Changed in charm-swift-storage:
milestone: none → 17.02
James Page (james-page)
Changed in charm-swift-storage:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.