Juniper Openstack

[UI] Remove usage of hard-coded default-domain in UI code

Bug #1582647 reported by Biswajit Mandal
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.0
Fix Committed
Undecided
Rahul
Juniper Openstack r3.0.2.0
Trunk
Fix Committed
Undecided
Rahul
Juniper Openstack r3.1.0.0-fcs

Bug Description

In many places of UI code, we are using hard-coded default-domain, so this needs to be changed.
In case of front-end code, we need to replace it using contrail.getCookie('domain') and in case of server side, we need to get it through req.cookies.domain.

Tags: ui
Biswajit Mandal (bmandal)
Changed in juniperopenstack:
assignee: nobody → Rahul (rahuls)
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/20431
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/20433
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/20431
Submitter: Biswajit Mandal (<email address hidden>)

Jeba Paulaiyan (jebap)
information type: Proprietary → Public
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/20433
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/20431
Committed: http://github.org/Juniper/contrail-web-core/commit/25337aaf1ef041df9cce64ec11dbcba02fe00ef3
Submitter: Zuul
Branch: master

commit 25337aaf1ef041df9cce64ec11dbcba02fe00ef3
Author: Biswajit Mandal <email address hidden>
Date: Fri May 20 10:12:11 2016 +0530

Related-Bug: #1582647
If project uuid is "all" (request came from network monitoring pages for all
projects) for get-project-role UI, then do for all projects internally and
update the tokenObjs for all projects.

Change-Id: I83fba95c9ef3683c9c038606cf6ee079c269eab0

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/20555
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/20650
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/20651
Submitter: Biswajit Mandal (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/20651
Committed: http://github.org/Juniper/contrail-web-core/commit/d78cc1b847a54b8b34b9f66205a305dc7cb45d1f
Submitter: Zuul
Branch: R3.0

commit d78cc1b847a54b8b34b9f66205a305dc7cb45d1f
Author: Biswajit Mandal <email address hidden>
Date: Mon Apr 11 09:35:42 2016 +0530

Closes-Bug: #1567216
filter out projects which are disabled in project-list from keystone

Change-Id: I049028a64e48ad58095ac750cc20336a5ccde61a
(cherry picked from commit ef60570d262b2be9e334a3be367dd572b053cbd9)

Related-Bug: #1582647
If project uuid is "all" (request came from network monitoring pages for all
projects) for get-project-role UI, then do for all projects internally and
update the tokenObjs for all projects.

Change-Id: I83fba95c9ef3683c9c038606cf6ee079c269eab0
(cherry picked from commit 25337aaf1ef041df9cce64ec11dbcba02fe00ef3)

Closes-Bug: #1582647
This reverts the change in CL 83096bc19ff04b7c42d8894597d8e3ae7a2569b4,
So for "all" project, we do not do project sync, as it may lead to performance
issues if there are thousands of projects, so by issuing individual project, we
will sync from keystone to API Server if not done already.

Change-Id: Icd00bed3fa9154c03cf3baffd4a13d626ba6c4b3
(cherry picked from commit 72f19ca0de400c79f9511703096723edffaa5ae5)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/20650
Committed: http://github.org/Juniper/contrail-web-controller/commit/a3478f9b282ff88012969c85be12bed800d025b3
Submitter: Zuul
Branch: R3.0

commit a3478f9b282ff88012969c85be12bed800d025b3
Author: Biswajit Mandal <email address hidden>
Date: Thu May 19 22:47:18 2016 +0530

Related-Bug: #1582647
Removal of hard-coded 'default-domain' across pages.
Changed of ignoreError false to true as VN get may fail for new project which is not
in sync with API Server.

Change-Id: Ibf81d6d5822f37f50339ba553380aa59522d938b
(cherry picked from commit dafe0ae89a01c12b93dce30eafa6fa66aab1a824)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/20433
Committed: http://github.org/Juniper/contrail-web-controller/commit/dafe0ae89a01c12b93dce30eafa6fa66aab1a824
Submitter: Zuul
Branch: master

commit dafe0ae89a01c12b93dce30eafa6fa66aab1a824
Author: Biswajit Mandal <email address hidden>
Date: Thu May 19 22:47:18 2016 +0530

Related-Bug: #1582647
Removal of hard-coded 'default-domain' across pages.
Changed of ignoreError false to true as VN get may fail for new project which is not
in sync with API Server.

Change-Id: Ibf81d6d5822f37f50339ba553380aa59522d938b

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/20555
Committed: http://github.org/Juniper/contrail-web-core/commit/72f19ca0de400c79f9511703096723edffaa5ae5
Submitter: Zuul
Branch: master

commit 72f19ca0de400c79f9511703096723edffaa5ae5
Author: Biswajit Mandal <email address hidden>
Date: Tue May 24 10:00:37 2016 +0530

Closes-Bug: #1582647
This reverts the change in CL 83096bc19ff04b7c42d8894597d8e3ae7a2569b4,
So for "all" project, we do not do project sync, as it may lead to performance
issues if there are thousands of projects, so by issuing individual project, we
will sync from keystone to API Server if not done already.

Change-Id: Icd00bed3fa9154c03cf3baffd4a13d626ba6c4b3

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.