EasySlides importer causes traceback on unexpected chars
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Committed
|
Low
|
Tomas Groth |
Bug Description
Reported here, includes example file: https:/
If an unexpected (control) char sneaks into the song data, OpenLP throws a traceback:
--- Exception Traceback ---
Traceback (most recent call last):
File "openlp\
File "openlp\
perform_wizard
File "openlp\
do_import
File "lxml.etree.pyx", line 3310, in lxml.etree.parse
(src\lxml\
File "parser.pxi", line 1791, in lxml.etree.
(src\lxml\
File "parser.pxi", line 1817, in lxml.etree.
(src\lxml\
File "parser.pxi", line 1721, in lxml.etree.
(src\lxml\
File "parser.pxi", line 1122, in lxml.etree.
(src\lxml\
File "parser.pxi", line 580, in
lxml.etree.
(src\lxml\
File "parser.pxi", line 690, in lxml.etree.
(src\lxml\
File "parser.pxi", line 620, in lxml.etree.
(src\lxml\
File "<string>", line None
lxml.etree.
17081, column 62
Related branches
- Raoul Snyman: Approve
-
Diff: 316 lines (+132/-31)7 files modifiedopenlp/plugins/bibles/lib/http.py (+28/-22)
openlp/plugins/songs/lib/importers/easyslides.py (+1/-1)
openlp/plugins/songs/lib/importers/videopsalm.py (+8/-0)
tests/functional/openlp_plugins/songs/test_videopsalm.py (+2/-0)
tests/interfaces/openlp_plugins/bibles/test_lib_http.py (+11/-8)
tests/resources/videopsalmsongs/as-safe-a-stronghold2.json (+35/-0)
tests/resources/videopsalmsongs/videopsalm-as-safe-a-stronghold2.json (+47/-0)
Changed in openlp: | |
status: | In Progress → Fix Committed |
Changed in openlp: | |
milestone: | none → 2.5.1 |