[2.0rc1] Network model misconfigurations can silently break DHCP services
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Medium
|
Blake Rouse | ||
Bug Description
While doing the fix for bug #1600720, I noticed that if I added an IPv6 subnet to a VLAN attached to a rack interface which did not exist on the rack, DHCP services (for IPv4 and IPv6) went offline.
While I have proposed a fix for that specific issue[1], (so that IPv4 can now fail independently of IPv6), this is still a problem that needs more visibility. When DHCP configuration fails in this way, there is no warning or indication to the user that something is amiss. For example, when checking the service status in the rack controller details page, the DHCP services are either a green checkmark if it works, or nothing-at-all if it doesn't work.
Such a misconfiguration should alert the user in some other way, and cause the service status to change to a warning or error. Otherwise, the only indication of this problem is seeing the traceback in the log.
[1]:
https:/
Related branches
- Mike Pontillo (community): Approve
-
Diff: 1628 lines (+770/-208)22 files modifiedsrc/maasserver/api/tests/test_vlans.py (+40/-0)
src/maasserver/api/vlans.py (+8/-1)
src/maasserver/dhcp.py (+41/-61)
src/maasserver/exceptions.py (+0/-4)
src/maasserver/forms_vlan.py (+25/-0)
src/maasserver/migrations/builtin/maasserver/0056_add_description_to_fabric_and_space.py (+1/-1)
src/maasserver/migrations/builtin/maasserver/0095_vlan_relay_vlan.py (+23/-0)
src/maasserver/migrations/builtin/maasserver/0096_set_default_vlan_field.py (+24/-0)
src/maasserver/models/tests/test_vlan.py (+8/-0)
src/maasserver/models/vlan.py (+5/-0)
src/maasserver/static/js/angular/controllers/tests/test_vlan_details.js (+56/-3)
src/maasserver/static/js/angular/controllers/vlan_details.js (+126/-18)
src/maasserver/static/js/angular/factories/tests/test_vlans.js (+6/-3)
src/maasserver/static/js/angular/factories/vlans.js (+12/-7)
src/maasserver/static/partials/vlan-details.html (+97/-22)
src/maasserver/testing/factory.py (+3/-2)
src/maasserver/tests/test_dhcp.py (+27/-80)
src/maasserver/tests/test_forms_vlan.py (+70/-0)
src/maasserver/triggers/system.py (+56/-0)
src/maasserver/triggers/tests/test_system_listener.py (+114/-0)
src/maasserver/websockets/handlers/tests/test_vlan.py (+15/-0)
src/maasserver/websockets/handlers/vlan.py (+13/-6)
| summary: |
- [2.0rc2] Network model misconfigurations can silently break DHCP + [2.0rc1] Network model misconfigurations can silently break DHCP services |
| Mike Pontillo (mpontillo) wrote | #1 |
| Changed in maas: | |
| milestone: | none → 2.2.0 |
| assignee: | nobody → Blake Rouse (blake-rouse) |
| status: | Triaged → In Progress |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
Looks like the upcoming work for DHCP Relay in MAAS 2.2 will fix this. (Thanks Blake!)