OpenLP

Changing shortcut to a key that is already used produces traceback

Bug #1612187 reported by Azaziah
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Committed
Low
Azaziah
OpenLP 2.9.1

Bug Description

Changing shortcut to a key that is already used produces traceback.

Traceback (most recent call last):
  File "E:\bzr\openlp\trunk\openlp\core\ui\shortcutlistform.py", line 97, in keyReleaseEvent
    if self._validiate_shortcut(self._current_item_action(), key_sequence):
  File "E:\bzr\openlp\trunk\openlp\core\ui\shortcutlistform.py", line 433, in _validiate_shortcut
    text, for_display=True)
TypeError: warning_message() got an unexpected keyword argument 'for_display'

Trunk rev 2690 | Win 10

Related branches

lp://qastaging/~suutari-olli/openlp/change-blank-to-desktop-hotkey-to-esc
Tomas Groth: Approve
Tim Bentley: Approve
Diff: 438 lines (+89/-102)
12 files modified
openlp/core/common/settings.py (+6/-4)
openlp/core/ui/exceptiondialog.py (+1/-1)
openlp/core/ui/exceptionform.py (+1/-1)
openlp/core/ui/mainwindow.py (+16/-32)
openlp/core/ui/shortcutlistform.py (+3/-3)
openlp/core/ui/slidecontroller.py (+35/-30)
openlp/plugins/custom/lib/mediaitem.py (+1/-1)
openlp/plugins/songs/forms/editsongform.py (+1/-1)
resources/images/openlp-2.qrc (+0/-1)
tests/functional/openlp_core_ui/test_slidecontroller.py (+2/-25)
tests/functional/openlp_plugins/bibles/test_mediaitem.py (+21/-0)
tests/functional/openlp_plugins/bibles/test_swordimport.py (+2/-3)
Revision history for this message
Azaziah (suutari-olli) wrote :

        if not is_valid:
            text = translate('OpenLP.ShortcutListDialog',
                             'The shortcut "{key}" is already assigned to another action, please'
                             ' use a different shortcut.'
                             ).format(key=self.get_shortcut_string(key_sequence))
            self.main_window.warning_message(translate('OpenLP.ShortcutListDialog', 'Duplicate Shortcut'),
                                             text, for_display=True) <<<< THIS = TRACEBACK
            self.dialog_was_shown = True
        return is_valid

        if not is_valid:
            text = translate('OpenLP.ShortcutListDialog',
                             'The shortcut "{key}" is already assigned to another action, please'
                             ' use a different shortcut.'
                             ).format(key=self.get_shortcut_string(key_sequence))
            self.main_window.warning_message(translate('OpenLP.ShortcutListDialog', 'Duplicate Shortcut'),
                                             text)
            for_display = True < FIX?
            self.dialog_was_shown = True
        return is_valid

Changed in openlp:
assignee: nobody → Azaziah (suutari-olli)
Phill (phill-ridout)
Changed in openlp:
status: New → In Progress
Azaziah (suutari-olli)
Changed in openlp:
importance: Undecided → Low
Tim Bentley (trb143)
Changed in openlp:
status: In Progress → Fix Committed
milestone: none → 2.5.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.