Fuel for OpenStack

[swarm] Example plugin fails

Bug #1621429 reported by Dmitry Belyaninov on 2016-09-08

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Fuel for OpenStack	Fix Committed	Critical	Georgy Kibardin	Fuel for OpenStack 11.0
Mitaka	Fix Released	Critical	Georgy Kibardin	Fuel for OpenStack 9.1
Newton	Fix Released	High	Georgy Kibardin	Fuel for OpenStack 10.1

Bug Description

Detailed bug description:
There are four failed example plugin tests.
https://product-ci.infra.mirantis.net/job/9.x.system_test.ubuntu.plugins.fuel_plugin_example/56/

  File "/home/jenkins/workspace/9.x.system_test.ubuntu.plugins.fuel_plugin_example/fuelweb_test/tests/plugins/plugin_example/test_fuel_plugin_example.py", line 318, in deploy_neutron_example_ha
    self.fuel_web.update_plugin_data(cluster_id, plugin_name, options)
  File "/home/jenkins/workspace/9.x.system_test.ubuntu.plugins.fuel_plugin_example/fuelweb_test/models/fuel_web_client.py", line 2679, in update_plugin_data
    self.client.update_cluster_attributes(cluster_id, plugin_attributes)
......
  File "/home/jenkins/venv-nailgun-tests-2.9/local/lib/python2.7/site-packages/keystoneauth1/session.py", line 570, in request
    raise exceptions.from_response(resp, method, url)
BadRequest: Bad Request (HTTP 400)

app.log:
  File "/usr/lib/python2.7/site-packages/nailgun/api/v1/handlers/cluster.py", line 219, in PATCH
    objects.Cluster.patch_attributes(cluster, data)
  File "/usr/lib/python2.7/site-packages/nailgun/objects/cluster.py", line 400, in patch_attributes
    PluginManager.process_cluster_attributes(instance, data['editable'])
  File "/usr/lib/python2.7/site-packages/nailgun/plugins/manager.py", line 84, in process_cluster_attributes
    'Cannot enable plugin with legacy tasks unless '
InvalidData: Cannot enable plugin with legacy tasks unless propagate_task_deploy attribute is set

Steps to reproduce:
run the test
Expected results:
pass
Actual result:
fail
Reproducibility:
100%
Workaround:
<put your information here>
Impact:
<put your information here>
Description of the environment:
Operation system: <put your information here>
Versions of components: <put your information here>
Reference architecture: <put your information here>
Network model: <put your information here>
Related projects installed: <put your information here>
Additional information:
<put your information here>

Tags:

Revision history for this message

Georgy Kibardin (gkibardin) wrote on 2016-09-08:

fuel_example_plugin_v3 and before contains non empty tasks.yaml and, therefore, cannot be enabled unless propagate_task_deploy flag is set. Moreover, https://github.com/openstack/fuel-plugins/blob/master/examples/fuel_plugin_example_v3/deployment_tasks.yaml tasks version is not set, rendering them as legacy.

Changed in fuel:
assignee:	Fuel Sustaining (fuel-sustaining-team) → Fuel QA Team (fuel-qa)
status:	New → Confirmed

Alexander Kurenyshev (akurenyshev) on 2016-09-08

Changed in fuel:
assignee:	Fuel QA Team (fuel-qa) → Georgy Kibardin (gkibardin)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-09: Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/367750

Georgy Kibardin (gkibardin) on 2016-09-09

Changed in fuel:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-09: Change abandoned on fuel-web (stable/mitaka)

Change abandoned by Georgy Kibardin (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/367750

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-09: Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/367930

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-12: Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/367930
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=d00f3d9228496bf25354dd4d6b6bdeaceecc2ad1
Submitter: Jenkins
Branch: stable/mitaka

commit d00f3d9228496bf25354dd4d6b6bdeaceecc2ad1
Author: Georgy Kibardin <email address hidden>
Date: Fri Sep 9 13:24:53 2016 +0300

Enable propagate_task_deploy in Web UI

    So that it could be set by a user.
    Also error message is returned in a structured way so that UI could
    display it.
    Also partial update of cluster attributes is supported.

Change-Id: Ib4a434039213cc91e0514240e722b7266f158ec5
Closes-Bug: #1621429

tags:

added: in-stable-mitaka

Georgy Kibardin (gkibardin) on 2016-09-12

Changed in fuel:
status:	In Progress → Fix Committed

Dmitry Belyaninov (dbelyaninov) on 2016-09-13

tags:

added: on-verification

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-16: Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/371393

Georgy Kibardin (gkibardin) on 2016-09-16

Changed in fuel:
status:	Fix Committed → In Progress
importance:	High → Critical

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-16: Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/371393
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=ab56109c3d18d57229b56e7908cc89b18677a2e6
Submitter: Jenkins
Branch: stable/mitaka

commit ab56109c3d18d57229b56e7908cc89b18677a2e6
Author: Georgy Kibardin <email address hidden>
Date: Fri Sep 16 12:26:14 2016 +0300

Merge values correctly

We only need to overwrite db value when a new value present in the
update message.

Change-Id: I53dfc338cbf0a57fc8537104efad3ec0330e1184
Closes-Bug: #1621429

Dmitry Pyzhov (dpyzhov) on 2016-09-16

Changed in fuel:
milestone:	9.1 → 10.0

Revision history for this message

ElenaRossokhina (esolomina) wrote on 2016-09-20:

Verified on 9.1 snapshot #284
CUSTOM_VERSION=snapshot #284
MAGNET_LINK=magnet:?xt=urn:btih:bfec808dd71ff42c5613a3527733d9012bb1fabc&dn=MirantisOpenStack-9.0.iso&tr=http%3A%2F%2Ftracker01-bud.infra.mirantis.net%3A8080%2Fannounce&tr=http%3A%2F%2Ftracker01-scc.infra.mirantis.net%3A8080%2Fannounce&tr=http%3A%2F%2Ftracker01-msk.infra.mirantis.net%3A8080%2Fannounce&ws=http%3A%2F%2Fvault.infra.mirantis.net%2FMirantisOpenStack-9.0.iso
FUEL_QA_COMMIT=19502443f1ed873aa0ee004e96293069fae7a9a9
UBUNTU_MIRROR_ID=ubuntu-2016-09-14-213640
CENTOS_MIRROR_ID=centos-7.2.1511-2016-05-31-083834
MOS_UBUNTU_MIRROR_ID=9.0-2016-09-19-122321
MOS_CENTOS_OS_MIRROR_ID=os-2016-06-23-135731
MOS_CENTOS_PROPOSED_MIRROR_ID=proposed-2016-09-19-152353
MOS_CENTOS_UPDATES_MIRROR_ID=updates-2016-06-23-135916
MOS_CENTOS_HOLDBACK_MIRROR_ID=holdback-2016-06-23-140047
MOS_CENTOS_HOTFIX_MIRROR_ID=hotfix-2016-09-16-084322
MOS_CENTOS_SECURITY_MIRROR_ID=security-2016-06-23-140002

tags:

removed: on-verification

Tatyana Borukhovich (tatyanaborukhovich) on 2016-09-23

tags:

removed: swarm-blocker

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-26: Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/376629

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-09-29: Change abandoned on fuel-web (master)

#10

Change abandoned by Georgy Kibardin (<email address hidden>) on branch: master
Review: https://review.openstack.org/376629

Revision history for this message

ElenaRossokhina (esolomina) wrote on 2016-10-10:

#11

4 tests failed from https://product-ci.infra.mirantis.net/job/10.0.system_test.ubuntu.plugins.fuel_plugin_example/147/

in app.log:
2016-10-10 12:16:17.626 ERROR [7f87d888f880] (base) NailgunException occured
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nailgun/api/v1/handlers/base.py", line 298, in handle_errors
    return func(cls, *args, **kwargs)
  File "<string>", line 2, in PATCH
  File "/usr/lib/python2.7/site-packages/nailgun/api/v1/handlers/base.py", line 356, in validate
    return func(cls, *args, **kwargs)
  File "<string>", line 2, in PATCH
  File "/usr/lib/python2.7/site-packages/nailgun/api/v1/handlers/base.py", line 382, in serialize
    resp = func(cls, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/nailgun/api/v1/handlers/cluster.py", line 249, in PATCH
    objects.Cluster.patch_attributes(cluster, data)
  File "/usr/lib/python2.7/site-packages/nailgun/objects/cluster.py", line 410, in patch_attributes
    PluginManager.process_cluster_attributes(instance, data['editable'])
  File "/usr/lib/python2.7/site-packages/nailgun/plugins/manager.py", line 87, in process_cluster_attributes
    'Cannot enable plugin with legacy tasks unless '
InvalidData: Cannot enable plugin with legacy tasks unless propagate_task_deploy attribute is set

tags:

added: swarm-blocker

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-21: Fix merged to fuel-web (master)

#12

Reviewed: https://review.openstack.org/376629
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=888ceb369354fe376190832d221e327c9105c99c
Submitter: Jenkins
Branch: master

commit 888ceb369354fe376190832d221e327c9105c99c
Author: Georgy Kibardin <email address hidden>
Date: Fri Sep 9 13:24:53 2016 +0300

Enable propagate_task_deploy in Web UI

    So that it could be set by a user.
    Also error message is returned in a structured way so that UI could
    display it.
    Also partial update of cluster attributes is supported.

    Change-Id: Ib4a434039213cc91e0514240e722b7266f158ec5
    Closes-Bug: #1621429
    (cherry picked from commit d00f3d9228496bf25354dd4d6b6bdeaceecc2ad1)

Changed in fuel:
status:	In Progress → Fix Committed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-21: Fix proposed to fuel-web (master)

#13

Fix proposed to branch: master
Review: https://review.openstack.org/389653

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-10-25: Fix merged to fuel-web (master)

#14

Reviewed: https://review.openstack.org/389653
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=4ed7c7fef289e94cf6bc0026c1da5493af0fcf31
Submitter: Jenkins
Branch: master

commit 4ed7c7fef289e94cf6bc0026c1da5493af0fcf31
Author: Georgy Kibardin <email address hidden>
Date: Fri Sep 16 12:26:14 2016 +0300

Merge values correctly

We only need to overwrite db value when a new value present in the
update message.

    Change-Id: I53dfc338cbf0a57fc8537104efad3ec0330e1184
    Closes-Bug: #1621429
    (cherry picked from commit ab56109c3d18d57229b56e7908cc89b18677a2e6)

Revision history for this message

Sergey Novikov (snovikov) wrote on 2016-12-05:

#15

@gkibardin could you please backport your patch to stable/newton. Some tests from swarm 10.0 fails with this error

Changed in fuel:
milestone:	10.0 → 11.0

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-06: Fix proposed to fuel-web (stable/newton)

#16

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/407337

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-06: Fix merged to fuel-web (stable/newton)

#17

Reviewed: https://review.openstack.org/407337
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=2af477444a2d7abe6dc7022c1f3cd954011eae8d
Submitter: Jenkins
Branch: stable/newton

commit 2af477444a2d7abe6dc7022c1f3cd954011eae8d
Author: Georgy Kibardin <email address hidden>
Date: Fri Sep 9 13:24:53 2016 +0300

Enable propagate_task_deploy in Web UI

    So that it could be set by a user.
    Also error message is returned in a structured way so that UI could
    display it.
    Also partial update of cluster attributes is supported.

    Change-Id: Ib4a434039213cc91e0514240e722b7266f158ec5
    Closes-Bug: #1621429
    (cherry picked from commit d00f3d9228496bf25354dd4d6b6bdeaceecc2ad1)
    (cherry picked from commit 888ceb369354fe376190832d221e327c9105c99c)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-06: Fix proposed to fuel-web (stable/newton)

#18

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/407419

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-06: Fix merged to fuel-web (stable/newton)

#19

Reviewed: https://review.openstack.org/407419
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=1b1fede8a369c626a445453804e20dd6a41daafb
Submitter: Jenkins
Branch: stable/newton

commit 1b1fede8a369c626a445453804e20dd6a41daafb
Author: Georgy Kibardin <email address hidden>
Date: Fri Sep 16 12:26:14 2016 +0300

Merge values correctly

We only need to overwrite db value when a new value present in the
update message.

    Change-Id: I53dfc338cbf0a57fc8537104efad3ec0330e1184
    Closes-Bug: #1621429
    (cherry picked from commit ab56109c3d18d57229b56e7908cc89b18677a2e6)
    (cherry picked from commit 4ed7c7fef289e94cf6bc0026c1da5493af0fcf31)