Fix `fuel2 graph execute` arguments list

Bug #1621831 reported by Alexander Kurenyshev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Bulat Gaifullin

Bug Description

According to the merged spec [1] we have the following list of args:

   fuel2 graph execute --env 1 [--nodes 1 2 3]
                                [--graph-types gtype1 gtype2]
                                [--task-names task1 task2]
                                [--force]
                                [--dry-run]

where

* ``--nodes`` executes only on passed nodes;
* ``--graph-types`` executes passed graphs within one transaction;
* ``--task-names`` executes only passed tasks skipping others;
* ``--force`` executes tasks anyway;
* ``--dry-run`` executes in dry-run mode (doesn't affect nodes)

But in fact:
[root@nailgun ~]# fuel2 graph execute
usage: fuel2 graph execute [-h] -e ENV [-t TYPES [TYPES ...]]
                           [-n NODES [NODES ...]]
                           [-T TASK_NAMES [TASK_NAMES ...]] [-d] [-f] [--noop]

So all those arguments are not really here:

[root@nailgun ~]# fuel2 graph execute --env 1 --graph-types my_graph
usage: fuel2 graph execute [-h] -e ENV [-t TYPES [TYPES ...]]
                           [-n NODES [NODES ...]]
                           [-T TASK_NAMES [TASK_NAMES ...]] [-d] [-f] [--noop]
fuel2 graph execute: error: unrecognized arguments: --graph-types my_graph

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 495
cat /etc/fuel_build_number:
 495
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 python-fuelclient-9.0.0-1.mos347.noarch
 fuel-setup-9.0.0-1.mos6352.noarch
 rubygem-astute-9.0.0-1.mos764.noarch
 fuel-migrate-9.0.0-1.mos8578.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-nailgun-9.0.0-1.mos8816.noarch
 fuel-misc-9.0.0-1.mos8578.noarch
 python-packetary-9.0.0-1.mos148.noarch
 fuel-9.0.0-1.mos6352.noarch
 fuel-ui-9.0.0-1.mos2799.noarch
 nailgun-mcagents-9.0.0-1.mos764.noarch
 network-checker-9.0.0-1.mos74.x86_64
 fuel-utils-9.0.0-1.mos8578.noarch
 fuel-library9.0-9.0.0-1.mos8578.noarch
 fuel-mirror-9.0.0-1.mos148.noarch
 fuel-ostf-9.0.0-1.mos944.noarch
 fuel-notify-9.0.0-1.mos8578.noarch
 fuel-agent-9.0.0-1.mos289.noarch
 fuel-release-9.0.0-1.mos6352.noarch
 fuel-bootstrap-cli-9.0.0-1.mos289.noarch
 fuelmenu-9.0.0-1.mos275.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8816.noarch
 fuel-openstack-metadata-9.0.0-1.mos8816.noarch

[1] https://review.openstack.org/#/c/343256/13/specs/10.0/graph-concept-extension.rst

Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Fuel Toolbox (fuel-toolbox)
Changed in fuel:
status: New → Confirmed
tags: added: area-python
Changed in fuel:
assignee: Fuel Toolbox (fuel-toolbox) → Alexey Shtokolov (ashtokolov)
Changed in fuel:
assignee: Alexey Shtokolov (ashtokolov) → Fuel Toolbox (fuel-toolbox)
Changed in fuel:
assignee: Fuel Toolbox (fuel-toolbox) → Bulat Gaifullin (bgaifullin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/369984

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/369991

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/369984
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=29cf9b2a0af1ff896a7051b9f455d6ddbeb5a884
Submitter: Jenkins
Branch: master

commit 29cf9b2a0af1ff896a7051b9f455d6ddbeb5a884
Author: Bulat Gaifullin <email address hidden>
Date: Wed Sep 14 12:44:19 2016 +0300

    Fix arguments list for graph and sequence execute

    The names of arguments was update according to specification.
    Also added additional argument '--trace' which enables
    debugging mode in tasks executor.

    Change-Id: I7565e79059138ea28533e495e9d773195128f358
    Closes-Bug: 1621831

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (stable/mitaka)

Reviewed: https://review.openstack.org/369991
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=3f9dadf3ec5e0ef05235ec9d1a26cbcce4ea1536
Submitter: Jenkins
Branch: stable/mitaka

commit 3f9dadf3ec5e0ef05235ec9d1a26cbcce4ea1536
Author: Bulat Gaifullin <email address hidden>
Date: Wed Sep 14 12:44:19 2016 +0300

    Fix arguments list for graph and sequence execute

    The names of arguments was update according to specification.
    Also added additional argument '--trace' which enables
    debugging mode in tasks executor.

    Change-Id: I7565e79059138ea28533e495e9d773195128f358
    Closes-Bug: 1621831

tags: added: in-stable-mitaka
tags: added: on-verification
Changed in fuel:
status: Fix Committed → Fix Released
Revision history for this message
Tatyana Kuterina (tkuterina) wrote :

Verified on 9.1 snapshot #264

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.